Re: [PATCH 1/2] dt-bindings: ufs: Document static TX Equalization settings properties

Conor Dooley
2026-05-01T17:03:04Z

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

On Fri, May 01, 2026 at 06:44:17AM -0700, Can Guo wrote:
> HW design team usually provides static TX Equalization settings based on
> PCB board characteristics. These settings can be passed from the device
> tree to configure the TX Equalization parameters (PreShoot, DeEmphasis,
> and PreCodeEn) for Host and Device across different HS gears.

I'm not familiar enough with ufs stuff to tell, but this commit message
sounds very qcom specific, but this is being added to a common file.
I'd like to see a lot more detail in the commit message, detailing why
this is truly applicable across IP vendors.

>
> Add patternProperties for txeq-settings-g[1-6] to support specifying
> static TX Equalization settings.
>
> Signed-off-by: Can Guo <can.guo@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/ufs/ufs-common.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> index ed97f5682509..bc83948fc168 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> @@ -105,6 +105,17 @@ properties:
> Restricts the UFS controller to rate-a or rate-b for both TX and
> RX directions.
>
> +patternProperties:
> + "^txeq-settings-g[1-6]$":
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 6
> + maxItems: 12
> + description: |
> + Static TX Equalization settings for High Speed (HS) gears.
> + The settings are specified as an array of tuples (PreShoot, DeEmphasis, PrecodeEn).
> + The array must contain these tuples in the following order:
> + Host Lane 0, [Host Lane 1], Device Lane 0, [Device Lane 1].
> +
> dependencies:
> freq-table-hz: [ clocks ]
> operating-points-v2: [ clocks, clock-names ]
> --
> 2.34.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]