Re: [PATCH net-next 09/12] gpio: tc956x: add TC956x/QPS615 support

Andrew Lunn
2026-05-01T18:36:54Z

> + * There is a TC956X PCI power controller driver that accesses the
> + * direction and output value registers for GPIOs 2 and 3. These
> + * GPIOs control the reset signal for the two downstream PCIe ports.
> + * Their values will never change during operation of this driver, and
> + * this driver reserves these two GPIOS.

Why doesn't this power controller driver actually use this driver to
control the GPIOs? Chicken/egg?

Maybe add a comment why gpio-regmap.c cannot be used. You probably
need to instantiate it twice, but i still think you will end up with
less code.

Andrew