Re: [PATCH net-next 04/12] net: stmmac: dma: create a separate dma_device pointer

Andrew Lunn
2026-05-01T17:14:16Z

> if (priv->dma_cap.host_dma_width) {
> - ret = dma_set_mask_and_coherent(device,
> - DMA_BIT_MASK(priv->dma_cap.host_dma_width));
> + u64 mask = DMA_BIT_MASK(priv->dma_cap.host_dma_width);
> +
> + ret = dma_set_mask_and_coherent(priv->dma_device, mask);

I'm nitpicking, but i don't think you need to introduce mask.
DMA_BIT_MASK... is already on a line of its own, and is within the 80
limit. Nothing changes here with s/device/priv->dma_device/

Andrew