Devicetree
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut+renesas@mailbox.org>
To: devicetree@vger.kernel.org
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Andy Whitcroft <apw@canonical.com>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Joe Perches <joe@perches.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Rob Herring <robh@kernel.org>,
	linux-renesas-soc@vger.kernel.org
Subject: [PATCH] checkpatch: Update DT bindings should be a separate patch text
Date: Sat,  2 May 2026 21:10:11 +0200	[thread overview]
Message-ID: <20260502191052.94729-1-marek.vasut+renesas@mailbox.org> (raw)

The current message can be slightly misleading, because it triggers
on a patchset which contains the following sequence of patches, even
if the bindings and headers are clearly a separate patch:

0001 ... patch which contains the DT .yaml bindings
000m ... unrelated patches
000n ... patch which contains DT headers <--- this emits the warning

The intention of this message is to indicate, that the bindings and
headers must be in the same 0001 patch, and the headers must not be
in the separate 000n patch. The patchset must be structured as follows:

0001 ... patch which contains the DT .yaml bindings + DT headers
000m ... unrelated patches
000n ... unrelated patches

Reword the warning for improved clarity.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: Joe Perches <joe@perches.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
NOTE: This comes from discussion with Krzysztof at
      https://lore.kernel.org/linux-arm-kernel/d246edd2-5f9d-4e95-850d-abff175088a6@kernel.org/
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3727156e4ccad..e505ba0666bdc 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2957,7 +2957,7 @@ sub process {
 				if (($last_binding_patch != -1) &&
 				    ($last_binding_patch ^ $is_binding_patch)) {
 					WARN("DT_SPLIT_BINDING_PATCH",
-					     "DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst\n");
+					     "DT binding docs and includes should be a single patch, but separate from this patch. See: Documentation/devicetree/bindings/submitting-patches.rst\n");
 				}
 			}
 
-- 
2.53.0


             reply	other threads:[~2026-05-02 19:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-02 19:10 Marek Vasut [this message]
2026-05-02 20:03 ` [PATCH] checkpatch: Update DT bindings should be a separate patch text Joe Perches
2026-05-02 21:03   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260502191052.94729-1-marek.vasut+renesas@mailbox.org \
    --to=marek.vasut+renesas@mailbox.org \
    --cc=apw@canonical.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox