From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9FD31A549; Sun, 3 May 2026 02:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777774470; cv=none; b=hFwVkMKLQHHagQHukfQaogc1QdyCBkBe2i27lGvQ94YScnvNV2eLPWg2Bdo2akD3LZi4i+p7SssIqKf9vkxvp7iy1+UTKxBp89aYDH6F0rgQVPwwuqt283MP6FRYOg11wS6H7P3/dxSedn69VrV+m+VDl4OyTqs52TgKpsNIMN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777774470; c=relaxed/simple; bh=WrE0mBieKMvVSSs7pOWhhotigsQi1SiBQNbII0L224I=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dgDrfAaYmxGbo9Egtj25WIPf5/pkqVVx+jF/wMA/ogKHSAeGaI/FZ1ZmleBQvh0ZYjZW0xYENYOAU1QUzA0ZqCMNS/+yXEwac62BN0cA3TvaAbW8SZqfpK/3AJXesSiTrcM+RgxOfFqxtOcOPvo9wP4j8XLlTLXy9xjO4R1VuMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=luD2Nriv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="luD2Nriv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A71FC19425; Sun, 3 May 2026 02:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777774470; bh=WrE0mBieKMvVSSs7pOWhhotigsQi1SiBQNbII0L224I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=luD2NrivuOz6+qE1pSR5XkhLqWFdneRIkn2WNostSMg1HqThOxgRNL6fidSulRf1w mWVdqW89dMACy03eo9Zv08sfjzk2cTvVliKrFCmpttr48ku+GXQ/4sDgompfv54adv pqlh+63F9DHQ4axILVjqOjC1WcUl4Ezf294Yd2ebK842lnMTOyqK3hHu9YxMUDOcnF 3Aq6gDSUe14G8y74tGXSpIAOXGmQcxNsFuVsVBHy+43Y5fX3GqQ/cE4WSlhosPkH1z u+TA3dOa0WmhNZjayRyBJGTMgqRsPaB4toy1GvGAV4tRi9lCTCAiQ3S4pR7I+BpLIk wf38VcnjgXhqQ== Date: Sat, 2 May 2026 19:14:27 -0700 From: Jakub Kicinski To: Alex Elder Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 11/12] misc: tc956x_pci: add TC956x/QPS615 support Message-ID: <20260502191427.34048082@kernel.org> In-Reply-To: <649428a4-9505-4a1a-bbbe-bd90be9b8155@riscstar.com> References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-12-elder@riscstar.com> <20260502094559.15c3f479@kernel.org> <649428a4-9505-4a1a-bbbe-bd90be9b8155@riscstar.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 2 May 2026 21:06:33 -0500 Alex Elder wrote: > > drivers/misc/tc956x_pci.c:541:17: error: call to undeclared function 'u32_get_bits'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > > 541 | chip->rev_id = u32_get_bits(val, NCID_REV_ID_MASK); > > | ^ > > Yeah I think I noticed an error like that shows up with 32-bit builds? > In any case we didn't see it during development, and we'll make sure > gets included. on x86 it hits on all configs, I suspected you're building for ARM?