From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD1743A785E; Sun, 3 May 2026 21:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777844596; cv=none; b=p8KWyjemtfjPjn7Fy1+jUCJQu3u0O8QTG33LsQY9uXruTJZdzUuCvDB7tGRwerz5up68/KnfqQV3vZ577rrQYCtyu4Q6E8CyV45frr/2FkDwBeyZO5VKIw6azWtrpmX8KdBIp7znQey/BR6G7E5V/zFUhWM+tOc5ewZ10Ll20tk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777844596; c=relaxed/simple; bh=cWFq0UmsChy1UMKhJ3jNAc6iyXXgrydkyp2h6htMuew=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=autUzPk4CCb1gUCbQAPiMmWoQg0PCQNlsz07UwjBAyq8+os5uyJlc3k132tZpencSqEaqPisoXh45RIJz9EdEtGkSR5awUqBCzyydcItYKBzVBU8vgK38Mx1DYmq8LEl9cmnkWAVLHpEcS5N5/LuGrl9Vf+Ze7+Ovu7ZV0/2/+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s/Abf71z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s/Abf71z" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6BE6DC2BCB4; Sun, 3 May 2026 21:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777844596; bh=cWFq0UmsChy1UMKhJ3jNAc6iyXXgrydkyp2h6htMuew=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=s/Abf71zdPGK2EH6TIc1GQX8Gg5oaMLMS9QIm6i3WcLbROvc+rJSGW2HnMgw86Twa bvs4ra6r7pivhFfegB/jcxRYuJrPNfbLW2XFwPKweWvwOm+bwL2oz1CrYfuQgEeMTb YtJRz+w2wXJjO9twWN08VUPQo8+KrOnH7To9jrFCNA5mDs2jzXcvz3rkqU+jB8kxvz C7kZjLNpDTkcADnbu0+eOu2RL53fvmnS9N0n/85fWIEbhjAjC9bHa8p/nUFNryyAF/ A6JJ/YBpKTBoAuRHKHwzK4M9zMbFgv2ud7kIMuWpiK1ALyMQzlZZs14VP9RgYAy6Fl C8iYRLCJbq9Qg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63012CD3424; Sun, 3 May 2026 21:43:16 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Sun, 03 May 2026 14:43:15 -0700 Subject: [PATCH v5 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with vin supply Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260503-expressatt_camera_flash-v5-1-95524506a799@gmail.com> References: <20260503-expressatt_camera_flash-v5-0-95524506a799@gmail.com> In-Reply-To: <20260503-expressatt_camera_flash-v5-0-95524506a799@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , Conor Dooley X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777844595; l=2722; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=zVrQqx9DX85PpInFmz437RLTadxI5BhJ9KjSu1CJI9w=; b=D34jREdsOmnrUJrEqDaIoKNsVbWPR6FSlZ+YLIU9a5KCB6+P96K7j5lAZrbwwVf3VBNfYsHep KYe3PPgiY4nBYV94MtPA/rEVS7keiM0iaKvmF2+a3dI3VKcT6UIAqau X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Some flash ICs use the same one-wire pulse-count protocol as the RT8515 but have only a single enable line for both flash and torch modes, plus an optional input voltage supply (e.g. a GPIO-controlled fixed regulator) that gates power to the chip. Make ent-gpios optional and add a vin-supply property to support these variants. Add a oneOf constraint requiring exactly one of ent-gpios or vin-supply. Add a binding example showing the single-GPIO configuration with an input supply. Assisted-by: Claude:claude-opus-4.6 Acked-by: Conor Dooley Reviewed-by: Linus Walleij Signed-off-by: Rudraksha Gupta --- .../devicetree/bindings/leds/richtek,rt8515.yaml | 34 +++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml index 0356371a6b01..ab3c5139132c 100644 --- a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml +++ b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml @@ -15,6 +15,10 @@ description: | current for each mode is defined in hardware using two resistors RFS and RTS. + Some flash ICs use the same one-wire pulse-count protocol but have + only a single enable line for both flash and torch modes. For these + single-channel variants, only enf-gpios is needed. + properties: compatible: const: richtek,rt8515 @@ -26,6 +30,11 @@ properties: ent-gpios: maxItems: 1 description: A connection to the 'ENT' (enable torch) pin. + Not present on single-channel flash ICs that use only one enable + line for both flash and torch modes. + + vin-supply: + description: Optional input supply for the flash IC. richtek,rfs-ohms: minimum: 7680 @@ -81,10 +90,15 @@ properties: required: - compatible - - ent-gpios - enf-gpios - led +oneOf: + - required: + - ent-gpios + - required: + - vin-supply + additionalProperties: false examples: @@ -108,4 +122,22 @@ examples: }; }; + - | + /* Single-channel flash IC with input supply */ + #include + #include + + led-controller { + compatible = "richtek,rt8515"; + enf-gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>; + vin-supply = <&flash_reg>; + richtek,rfs-ohms = <16000>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + }; + }; + ... -- 2.54.0