Re: [PATCH v2 1/5] dt-bindings: iio: adc: add xlnx,versal-sysmon binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On Sat, May 02, 2026 at 12:19:47PM +0100, Salih Erim wrote:
> Add devicetree binding for the AMD/Xilinx Versal System Monitor (SysMon).
> 
> The Versal SysMon is the successor to the Zynq UltraScale+ AMS block,
> providing on-chip voltage and temperature monitoring. The hardware
> supports up to 160 supply voltage measurement points and up to 64
> temperature satellites distributed across the SoC, with configurable
> threshold alarms and oversampling. The device can be accessed via
> memory-mapped I/O or via an I2C interface.
> 
> Supply and temperature channels are described as child nodes under
> container nodes, referencing the standard adc.yaml binding for
> channel properties.
> 
> Co-developed-by: Michal Simek <michal.simek@amd.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> Signed-off-by: Salih Erim <salih.erim@amd.com>
> ---
> Changes in v2:
>   - Restructured to container nodes (supply-channels, temperature-channels)
>     with channel@N children referencing adc.yaml
>   - Added xlnx,versal-sysmon-i2c compatible
>   - Descriptions rewritten to describe hardware only
>   - Example simplified to #address-cells = <1>
>   - Interrupt example uses GIC_SPI/IRQ_TYPE_LEVEL_HIGH constants
>   - Commit description explains hardware context instead of schema layout
>   - reg required for both MMIO and I2C, interrupts optional
>   - Hex unit-addresses (channel@a not channel@10) per DTSpec
>   - patternProperties regex updated to accept hex digits [0-9a-f]
>   - Example trimmed to minimal variants (one basic + one bipolar supply,
>     one AIE temperature channel)
>  .../bindings/iio/adc/xlnx,versal-sysmon.yaml  | 172 ++++++++++++++++++
>  1 file changed, 172 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/xlnx,versal-sysmon.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,versal-sysmon.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,versal-sysmon.yaml
> new file mode 100644
> index 00000000000..cdd8706fc02
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,versal-sysmon.yaml
> @@ -0,0 +1,172 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2022 - 2026, Advanced Micro Devices, Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/xlnx,versal-sysmon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMD/Xilinx Versal System Monitor
> +
> +maintainers:
> +  - Salih Erim <salih.erim@amd.com>
> +
> +description:
> +  The AMD/Xilinx Versal System Monitor (SysMon) is the successor to the
> +  Zynq UltraScale+ AMS block. It provides on-chip voltage and temperature
> +  monitoring with up to 160 supply voltage measurement points and up to
> +  64 temperature satellites distributed across the SoC. The hardware
> +  supports configurable threshold alarms and oversampling. The device
> +  can be accessed via memory-mapped I/O or via an I2C interface.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - xlnx,versal-sysmon
> +      - xlnx,versal-sysmon-i2c

This is explicitly mentioned in writing bindings. One device, one
compatible (not two, not three, not four compatibles).

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  '#io-channel-cells':
> +    const: 1
> +
> +  supply-channels:
> +    type: object
> +    description:
> +      Container for supply voltage measurement channels.

voltage, not supply. Supply is the source of energy coming to this
device. But are you measuring that source?

> +
> +    properties:
> +      '#address-cells':
> +        const: 1
> +
> +      '#size-cells':
> +        const: 0
> +
> +    patternProperties:
> +      "^channel@([0-9a-f]|[1-9][0-9a-f])$":

Keep consistent quotes, either ' or "

> +        $ref: adc.yaml
> +
> +        description:
> +          Measures a supply rail voltage. The register index and rail
> +          name are assigned by the hardware design tool (Vivado).
> +
> +        properties:
> +          reg:
> +            minimum: 0
> +            maximum: 159
> +            description:
> +              Supply measurement register index assigned by the hardware
> +              design tool.
> +
> +          label:
> +            description:
> +              Name of the supply rail being monitored.

Drop property, it's already in adc.yaml.

> +
> +          bipolar: true

Drop

> +
> +        required:
> +          - reg
> +          - label
> +
> +        unevaluatedProperties: false
> +
> +    required:
> +      - '#address-cells'
> +      - '#size-cells'
> +
> +    additionalProperties: false
> +
> +  temperature-channels:
> +    type: object
> +    description:
> +      Container for temperature satellite measurement channels.
> +
> +    properties:
> +      '#address-cells':
> +        const: 1
> +
> +      '#size-cells':
> +        const: 0
> +
> +    patternProperties:
> +      "^channel@([1-9a-f]|[1-3][0-9a-f]|40)$":
> +        $ref: adc.yaml
> +
> +        description:
> +          Reads a temperature satellite sensor. Each satellite monitors
> +          a specific region of the SoC die.
> +
> +        properties:
> +          reg:
> +            minimum: 1
> +            maximum: 64
> +            description:
> +              Temperature satellite number (1-based hardware index).
> +
> +          label:
> +            description:
> +              Name identifying this temperature satellite.

Drop property

> +
> +          xlnx,aie-temp:
> +            type: boolean
> +            description:
> +              Indicates this satellite monitors an AI Engine tile.

What for? What is on the other side of the channel is not really
relevant to this device, but rather to that other side (consumer).

> +
> +        required:
> +          - reg
> +          - label
> +
> +        unevaluatedProperties: false
> +
> +    required:
> +      - '#address-cells'
> +      - '#size-cells'
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg

Best regards,
Krzysztof