public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Piyush Patle <piyushpatle228@gmail.com>
To: Andreas Klinger <ak@it-klinger.de>, Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v6 10/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read
Date: Sun,  3 May 2026 17:39:39 +0530	[thread overview]
Message-ID: <20260503120949.80292-11-piyushpatle228@gmail.com> (raw)
In-Reply-To: <20260503120949.80292-1-piyushpatle228@gmail.com>

Change hx711_reset_read() to accept the channel descriptor directly and
update its callers accordingly.

Split the existing HX711 channel-selection work into a small helper so a
later variant-specific change can add a matching helper without growing
hx711_reset_read() further.

No functional change.

Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
---
 drivers/iio/adc/hx711.c | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c
index 98fb617ea32b..2229df17f350 100644
--- a/drivers/iio/adc/hx711.c
+++ b/drivers/iio/adc/hx711.c
@@ -269,7 +269,22 @@ static int hx711_set_gain_for_channel(struct hx711_data *hx711_data, int chan)
 	return 0;
 }
 
-static int hx711_reset_read(struct hx711_data *hx711_data, int chan)
+static int hx711_set_hx711_channel(struct hx711_data *hx711_data,
+				   const struct iio_chan_spec *chan,
+				   int *trailing_pulses)
+{
+	int ret;
+
+	ret = hx711_set_gain_for_channel(hx711_data, chan->channel);
+	if (ret < 0)
+		return ret;
+
+	*trailing_pulses = hx711_get_gain_to_pulse(hx711_data->gain_set);
+	return 0;
+}
+
+static int hx711_reset_read(struct hx711_data *hx711_data,
+			    const struct iio_chan_spec *chan)
 {
 	int trailing_pulses;
 	int ret;
@@ -283,11 +298,10 @@ static int hx711_reset_read(struct hx711_data *hx711_data, int chan)
 		return -EIO;
 	}
 
-	ret = hx711_set_gain_for_channel(hx711_data, chan);
+	ret = hx711_set_hx711_channel(hx711_data, chan, &trailing_pulses);
 	if (ret < 0)
 		return ret;
 
-	trailing_pulses = hx711_get_gain_to_pulse(hx711_data->gain_set);
 	return hx711_read(hx711_data, trailing_pulses);
 }
 
@@ -301,7 +315,7 @@ static int hx711_read_raw(struct iio_dev *indio_dev,
 	case IIO_CHAN_INFO_RAW:
 		mutex_lock(&hx711_data->lock);
 
-		*val = hx711_reset_read(hx711_data, chan->channel);
+		*val = hx711_reset_read(hx711_data, chan);
 
 		mutex_unlock(&hx711_data->lock);
 
@@ -391,8 +405,8 @@ static irqreturn_t hx711_trigger(int irq, void *p)
 	memset(&hx711_data->buffer, 0, sizeof(hx711_data->buffer));
 
 	iio_for_each_active_channel(indio_dev, i) {
-		hx711_data->buffer.channel[j] = hx711_reset_read(hx711_data,
-					indio_dev->channels[i].channel);
+		hx711_data->buffer.channel[j] =
+			hx711_reset_read(hx711_data, &indio_dev->channels[i]);
 		j++;
 	}
 
-- 
2.43.0


  parent reply	other threads:[~2026-05-03 12:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 12:09 [PATCH v6 00/11] iio: adc: hx711: add HX710B support Piyush Patle
2026-05-03 12:09 ` [PATCH v6 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text Piyush Patle
2026-05-03 12:09 ` [PATCH v6 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property Piyush Patle
2026-05-04  6:51   ` Krzysztof Kozlowski
2026-05-04 15:58     ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 03/11] dt-bindings: iio: adc: hx711: add RATE GPIO property Piyush Patle
2026-05-04  6:52   ` Krzysztof Kozlowski
2026-05-03 12:09 ` [PATCH v6 04/11] dt-bindings: iio: adc: hx711: add HX710B support Piyush Patle
2026-05-03 12:09 ` [PATCH v6 05/11] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-05-04 14:25   ` Andy Shevchenko
2026-05-04 16:00     ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 06/11] iio: adc: hx711: introduce hx711_chip_info structure Piyush Patle
2026-05-04 14:48   ` Andy Shevchenko
2026-05-03 12:09 ` [PATCH v6 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Piyush Patle
2026-05-03 12:09 ` [PATCH v6 08/11] iio: adc: hx711: split variable assignments in hx711_read and hx711_reset Piyush Patle
2026-05-04 15:46   ` Andy Shevchenko
2026-05-04 16:03   ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 09/11] iio: adc: hx711: localize loop iterators in hx711_read Piyush Patle
2026-05-04 15:48   ` Andy Shevchenko
2026-05-03 12:09 ` Piyush Patle [this message]
2026-05-04 16:05   ` [PATCH v6 10/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 11/11] iio: adc: hx711: add support for HX710B Piyush Patle
2026-05-04 15:52   ` Andy Shevchenko
2026-05-04 16:59     ` Jonathan Cameron
2026-05-04 16:02   ` Jonathan Cameron
2026-05-04 15:54 ` [PATCH v6 00/11] iio: adc: hx711: add HX710B support Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260503120949.80292-11-piyushpatle228@gmail.com \
    --to=piyushpatle228@gmail.com \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox