Re: [PATCH 01/13] dt-bindings: iio: adc: add mt6323 PMIC AUXADC

Krzysztof Kozlowski
2026-05-06T07:56:10Z

On 04/05/2026 20:24, Roman Vivchar via B4 Relay wrote:
> From: Roman Vivchar <rva333@protonmail.com>
>
> The MediaTek mt6323 PMIC includes an AUXADC used for battery voltage,
> temperature, and other internal measurements.
>
> Add the devicetree binding documentation and the associated header file
> defining the ADC channel constants.
>
> Tested-by: Ben Grisdale <bengris32@protonmail.ch> # Amazon Echo Dot (2nd Generation)

Sorry, but that's not possible or explain please how YAML file can be
tested on a device.

> Signed-off-by: Roman Vivchar <rva333@protonmail.com>
> ---
> .../bindings/iio/adc/mediatek,mt6323-auxadc.yaml | 39 ++++++++++++++++++++++
> .../dt-bindings/iio/adc/mediatek,mt6323-auxadc.h | 16 +++++++++
> 2 files changed, 55 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6323-auxadc.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6323-auxadc.yaml
> new file mode 100644
> index 000000000000..7dc1ac8bf253
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6323-auxadc.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/mediatek,mt6323-auxadc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT6323 PMIC AUXADC
> +
> +maintainers:
> + - Roman Vivchar <rva333@protonmail.com>
> +
> +description: >
> + The Auxiliary Analog/Digital Converter (AUXADC) is an ADC found
> + in the MediaTek MT6323 PMIC, performing various PMIC related measurements
> + such as battery and PMIC internal voltage regulators temperatures,
> + accessory detection resistance (usually, for a 3.5mm audio jack)
> + other than voltages for various PMIC internal components.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6323-auxadc
> +
> + "#io-channel-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - "#io-channel-cells"

This is heavily incomplete node... or unnecessarily split. Why it cannot
be part of parent binding? Or even parent node?

Best regards,
Krzysztof