Re: [PATCH v6 11/11] iio: adc: hx711: add support for HX710B

Andy Shevchenko
2026-05-04T15:53:01Z

On Sun, May 03, 2026 at 05:39:40PM +0530, Piyush Patle wrote:
> Add support for the AVIA HX710B ADC, which shares the HX711 GPIO
> interface but uses trailing PD_SCK pulses to select the active mode.
>
> Model the HX710B with variant-specific channel tables and IIO info,
> track the active channel across conversions, and use the fixed gain
> value when computing scale.
>
> Also update the adjacent Kconfig text, file header, and module
> description so the driver text matches the newly supported variant.

...

> /*
> * triggered buffer
> - * 2x32-bit channel + 64-bit naturally aligned timestamp
> + * up to 3x32-bit channels + pad + 64-bit naturally aligned timestamp
> */
> struct {
> - u32 channel[2];
> + u32 channel[3];
> + u32 pad;
> aligned_s64 timestamp;
> } buffer;

Maybe it's obvious to everybody, but me, however I find it difficult to see if
there is no ABI breakage. Can you add a comment explaining why this is not a
problem?

--
With Best Regards,
Andy Shevchenko