Re: [PATCH v6 00/11] iio: adc: hx711: add HX710B support

Andy Shevchenko
2026-05-04T15:54:25Z

On Sun, May 03, 2026 at 05:39:29PM +0530, Piyush Patle wrote:
> Add support for the AVIA HX710B ADC, a HX711-compatible converter with
> the same GPIO interface but a different channel-selection model and a
> fixed gain of 128.
>
> Compared to v5, this series is unchanged functionally and only folds in
> the remaining review nits:
>
> - keep the per-variant probe local declarations in reversed xmas tree
> order
> - add a preparatory split-assignment patch before the loop-iterator
> cleanup, then keep the loop indices signed to match trailing_pulses
> - replace the 24-bit read loop bound with a named constant while
> touching the same code
> - keep the driver wording aligned on "weigh sensor modules"
> - rename fixed_gain to has_fixed_gain and drop the channel_set cast
>
> The DT binding split from v5 is kept as-is:
>
> - cleanup of the existing HX711 binding text
> - HX711-only VSUP documentation
> - HX711-only RATE GPIO documentation
> - HX710B binding addition
>
> Tested on PocketBeagle2 with an HX710B breakout module. The device
> probed successfully, all three channels returned stable raw readings,
> and alternating reads confirmed channel switching between the
> differential input and the DVDD-AVDD supply monitor path.
>
> Build-tested with:
> - make -s W=1 drivers/iio/adc/hx711.o
> - make -s dt_binding_check \
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> - pahole -C hx711_chip_info drivers/iio/adc/hx711.o
>
> pahole reports hx711_chip_info as 40 bytes with no internal holes. The
> remaining 7 bytes are tail padding from 8-byte pointer alignment.

Some small issues here and there, either Jonathan is going to tweak, or if
v7 is going to address them, feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

--
With Best Regards,
Andy Shevchenko