Re: [RFC PATCH v3 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

Alexander Shiyan
2026-05-05T14:09:31Z

Hello Laurent.

> On Fri, Mar 06, 2026 at 01:36:13PM +0300, Alexander Shiyan wrote:
> > Add devicetree binding for the onsemi AR0234 CMOS image sensor.
> >
> > Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> > ---
> > .../bindings/media/i2c/onnn,ar0234.yaml | 109 ++++++++++++++++++
> > 1 file changed, 109 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> > new file mode 100644
> > index 000000000000..d93fa99e6535
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> > @@ -0,0 +1,109 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/onnn,ar0234.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ON Semiconductor AR0234 1/2.6-inch CMOS Digital Image Sensor
> > +
> > +description:
> > + The AR0234 is a 1/2.6-inch CMOS digital image sensor with a pixel
> > + array of 1940x1220 pixels, capable of 1920x1200 resolution at up
> > + to 120 fps. It supports MIPI CSI-2 output with 1, 2, or 4 data lanes,
> > + and raw Bayer (8/10-bit) or monochrome output.
> > +
> > +properties:
> > + compatible:
> > + const: onnn,ar0234cs
>
> Should we define separate compatible strings for the mono and colour
> variants ? I know you identify the variant at runtime in the driver, but
> avoid I2C communication at boot time can be beneficial (to reduce boot
> time, and also to avoid flashing the privacy LED on systems that have
> one, albeit the latter is probably less applicable to the AR0234).

We could do it like this — Color: ar0234cssc, Mono: ar0234cssm.
But the current approach is more universal...
Could we add two compatible strings and keep the base one for auto-detection?
For detection, it would still be good to check the identifier anyway...
Or just add two compatible strings but detect connected variant in any case?

Thanks!