From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E363B36C5BB; Wed, 6 May 2026 08:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778055662; cv=none; b=j4EIHPT3UGOORip8g8fBwyABGetvV6u55ZAiGWHm68jcTOWg/ilkNFNTS/iXCzSG6wcYDCGjkN5QCynn4cdgdo3R1vpz6f0e1kEsbea7M4Cip8KPr7va0E08gPvmF0FgKvP/lDlmtve/f7A/3l8SKpfATirjLVg+Xp4NVpcAmIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778055662; c=relaxed/simple; bh=G1nVPYRfl6s8rD9Wrm6hHq/1ImKn9a5LDjyEKm+0qkQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AsTO2ZU3ANc3JojKCXxSUICgjBoFYaCThnz4GonLkPMh/McJyFFmezpQF+YBJtJDuanLMWxaS0XDzAkcS8a1KZWq0aaL8VPulAb3YD52kJFk+Hf05rW34eCvbHiy9+FHccNUWTDlrsQqxRdpwcnuOjNd6vApR/OyLXP63i1SYtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ESpEGV3s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ESpEGV3s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9B1EC2BCB8; Wed, 6 May 2026 08:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778055661; bh=G1nVPYRfl6s8rD9Wrm6hHq/1ImKn9a5LDjyEKm+0qkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ESpEGV3sw6prPOvy2VWzP2bLdVwqTlr5OWx8qdIwByo7yhbxrrsvCCjmqkTbU5db9 CZlKMy7AcOBMw5QcTF+9XgT8ITvbXb+72MvRd69deR16tnWGRYHHbcrDPdeALjveGV VJauU8nkLmsSMZMO03dHZZ2QFWZNoUnPK4cg56DEgyofaEezyXTlriqu8zD41rKIsZ K/HRm+pI6FepSutdc21blOfSf47T8SO1WDavdxp8G8z4E7ZKbuBgbaCmmXYRiusdo/ 7+jml5OFxEn13NSrenxNNBQv63/XpaUHUow8oI3Ss8KNJRgjPE927GREcY2M4r7mrD YsO17ezTXEOFw== Date: Wed, 6 May 2026 10:20:58 +0200 From: Krzysztof Kozlowski To: Ciprian Regus Cc: Parthiban Veerasooran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Andrew Lunn , Heiner Kallweit , Russell King , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 5/5] dt-bindings: net: Add bindings for the ADIN1140 Message-ID: <20260506-important-simple-crayfish-6897fd@quoll> References: <20260503-adin1140-driver-v1-0-dd043cdd88f0@analog.com> <20260503-adin1140-driver-v1-5-dd043cdd88f0@analog.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260503-adin1140-driver-v1-5-dd043cdd88f0@analog.com> On Sun, May 03, 2026 at 02:24:54AM +0300, Ciprian Regus wrote: > Add DT bindings for the ADIN1140 10BASE-T1S MACPHY. Update the > MAINTAINERS entry to include the bindings file as well. Beside other review, two things since I expect a v2 anyway: A nit, subject: drop second/last, redundant "bindings for the". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Signed-off-by: Ciprian Regus > --- > .../devicetree/bindings/net/adi,adin1140.yaml | 69 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 70 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/adi,adin1140.yaml b/Documentation/devicetree/bindings/net/adi,adin1140.yaml > new file mode 100644 > index 000000000000..26cd40d36f9b > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/adi,adin1140.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/adi,adin1140.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ADI ADIN1140 10BASE-T1S MAC-PHY > + > +maintainers: > + - Ciprian Regus > + > +description: | > + The ADIN1140 (also called AD3306) is a low power single port > + 10BASE-T1S MAC-PHY. It integrates an Ethernet PHY with a MAC > + and all the associated analog circuitry. > + The device implements the Open Alliance TC6 10BASE-T1x MAC-PHY > + Serial Interface specification and is compliant with the > + IEEE 802.3cg-2019 Ethernet standard for 10 Mbps single pair > + Ethernet (SPE). The device has a 4-wire SPI interface for > + communication between the MAC and host processor. > + > +allOf: > + - $ref: /schemas/net/ethernet-controller.yaml# > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + enum: > + - adi,adin1140 > + - adi,ad3306 I guess reversed order as numbers are before letters in most sorting. Best regards, Krzysztof