Re: [PATCH 01/11] of: reserved_mem: fix region count for nodes with multiple reg entries

Rob Herring
2026-05-06T01:47:55Z

On Wed, Apr 29, 2026 at 02:58:21PM +0800, Chen Wandun wrote:
> When a reserved-memory node contains multiple reg entries (e.g.,
> reg = <base1 size1>, <base2 size2>), the count used for
> total_reserved_mem_cnt is wrong in two places:
>
> 1) __reserved_mem_reserve_reg() returns 0 on success regardless of how
> many regions it reserved in memblock. The caller in
> fdt_scan_reserved_mem() then increments count by just 1.

Just to make sure, more than 1 worked before the referenced commits? It
would be easier to just define we only expect/support 1 entry.

>
> 2) fdt_scan_reserved_mem_late() uses of_flat_dt_get_addr_size() which
> only reads the first reg entry. Subsequent entries are never
> initialized via fdt_init_reserved_mem_node(), so their metadata is
> lost.
>
> Fix both issues:
> - Make __reserved_mem_reserve_reg() return the actual number of
> regions successfully reserved. Update the caller to accumulate
> the returned count.
> - Rewrite fdt_scan_reserved_mem_late() to use
> of_flat_dt_get_addr_size_prop() and iterate all reg entries,
> initializing each one via fdt_init_reserved_mem_node().
>
> Fixes: 8a6e02d0c00e ("of: reserved_mem: Restructure how the reserved memory regions are processed")
> Fixes: 00c9a452a235 ("of: reserved_mem: Add code to dynamically allocate reserved_mem array")