Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: LiangCheng Wang <zaq14760@gmail.com>
Cc: airlied@gmail.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	onlywig@gmail.com, robh@kernel.org, simona@ffwll.ch,
	tzimmermann@suse.de
Subject: Re: [PATCH 1/2] dt-bindings: display: mayqueen,pixpaper: add pixpaper-426m
Date: Thu, 7 May 2026 18:08:25 +0100	[thread overview]
Message-ID: <20260507-bannister-bobsled-741e2b1e8451@spud> (raw)
In-Reply-To: <20260507023234.3655616-1-zaq14760@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

On Thu, May 07, 2026 at 10:32:34AM +0800, LiangCheng Wang wrote:
> Hi Conor,
> 
> Thanks for the review.
> 
> You're right on both points.
> 
> The new panel uses the same DT properties as the existing Pixpaper
> panel, but it requires a distinct compatible because the driver
> selects a different panel-specific initialization and update sequence.

Can't see what you're replying to, but please note this in the commit
message on your v2.

> 
> The second example is also redundant, so I'll drop it.
> 
> I'll fold these fixes into the next revision and wait a bit longer
> for any driver-side feedback before sending v2.
> 
> Thanks,
> LiangCheng

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-05-07 17:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06  6:25 [PATCH 0/2] Add support for PIXPAPER 4.26 monochrome e-ink panel LiangCheng Wang
2026-05-06  6:25 ` [PATCH 1/2] dt-bindings: display: mayqueen,pixpaper: add pixpaper-426m LiangCheng Wang
2026-05-06 16:58   ` Conor Dooley
2026-05-07  2:32     ` LiangCheng Wang
2026-05-07 17:08       ` Conor Dooley [this message]
2026-05-06  6:25 ` [PATCH 2/2] drm/tiny: add support for PIXPAPER 4.26 monochrome e-ink panel LiangCheng Wang
2026-05-19  8:44   ` LiangCheng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507-bannister-bobsled-741e2b1e8451@spud \
    --to=conor@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=onlywig@gmail.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=zaq14760@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox