Devicetree
 help / color / mirror / Atom feed
From: Chukun Pan <amadeus@jmu.edu.cn>
To: linux.amoon@gmail.com
Cc: alex@ghiti.fr, amadeus@jmu.edu.cn, aou@eecs.berkeley.edu,
	conor+dt@kernel.org, devicetree@vger.kernel.org, dlan@kernel.org,
	gaohan@iscas.ac.cn, huang.ze@linux.dev, krzk+dt@kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	palmer@dabbelt.com, pjw@kernel.org, robh@kernel.org,
	spacemit@lists.linux.dev
Subject: Re: [PATCH v2 4/4] riscv: dts: spacemit: k1-bananapi-f3: Add vin-supply for PCIe 3.3V regulator
Date: Thu,  7 May 2026 14:50:30 +0800	[thread overview]
Message-ID: <20260507065030.1883988-1-amadeus@jmu.edu.cn> (raw)
In-Reply-To: <20260502051906.8160-4-linux.amoon@gmail.com>

Hi,

> @@ -39,6 +39,7 @@ pcie_vcc_3v3: regulator-pcie-vcc3v3 {
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
>  		regulator-always-on;
> +		vin-supply = <&reg_vcc5v0_sys>;
>  	};

This is incorrect. pcie_vcc3v3 is driven by usbvbus (dc_in).

  parent reply	other threads:[~2026-05-07  6:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-02  5:18 [PATCH v2 0/4] spacemit: k1-bananapi-f3: Fix the power source of USB3 nodes Anand Moon
2026-05-02  5:18 ` [PATCH v2 1/4] riscv: dts: spacemit: k1-bananapi-f3: Add vcc5v0_sys regulator for Banana Pi F3 Anand Moon
2026-05-07  2:45   ` Yixun Lan
2026-05-08  7:36     ` Anand Moon
2026-05-09 12:18       ` Yixun Lan
2026-05-09 15:18         ` Anand Moon
2026-05-11  6:53           ` Yixun Lan
2026-05-02  5:18 ` [PATCH v2 2/4] riscv: dts: spacemit: k1-bananapi-f3: Update USB regulator on onboard usb and label Anand Moon
2026-05-07  6:40   ` Chukun Pan
2026-05-08  7:36     ` Anand Moon
2026-05-02  5:18 ` [PATCH v2 3/4] riscv: dts: spacemit: k1-bananapi-f3: Correct USB hub power hierarchy Anand Moon
2026-05-07  6:50   ` Chukun Pan
2026-05-08  7:38     ` Anand Moon
2026-05-07  6:50   ` Chukun Pan [this message]
2026-05-02  5:18 ` [PATCH v2 4/4] riscv: dts: spacemit: k1-bananapi-f3: Add vin-supply for PCIe 3.3V regulator Anand Moon
2026-05-08  7:43   ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507065030.1883988-1-amadeus@jmu.edu.cn \
    --to=amadeus@jmu.edu.cn \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=gaohan@iscas.ac.cn \
    --cc=huang.ze@linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux.amoon@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox