From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F1823C0626; Thu, 7 May 2026 09:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778146007; cv=none; b=kWHLvC6jWCXThm/ulQg9Fk2R6J1qTan7UEJvUjJUeR1hBoXhvM18Wir5UiwA8gfR/I9BHwjz1l0P9Gx0h7Xj+udO6q52ipasTvD+zAhrR9EkpoYwGvitrgqcLTkr/EYUJGPN8Ti7e3DHOnhsESwWnjxOYDAvmzC8GkWde5j7LKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778146007; c=relaxed/simple; bh=n2k9d6Qmr2Qrr9CybM4JgqIb4aCIGw14I7nV7zxpHvc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RwtDgpgvLZ6RwYDDLdP9nTr2dgyldiDNpZLjeLGt2VYDP4Y8GBRABoV7NzWTHOkX2YxUnW6WYtIpMmdLWO5dLb8oJRjSs+tp8Igjk9LEVUHLFGNcrkRcgTZAndefj7AbmzkcjF9XyN8zPLUJJ6ypDDLr1CxTPv0jauKyRvg7N0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z1IOlUIw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z1IOlUIw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCDAEC2BCB8; Thu, 7 May 2026 09:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778146007; bh=n2k9d6Qmr2Qrr9CybM4JgqIb4aCIGw14I7nV7zxpHvc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z1IOlUIwK1CmoO17EvYml7T1LaDq46EFi5OMVpJf4C/bc53XtrzOOcHRD+NQTWbo+ RfjTNfhJjZNtzM0N4QKlvJLKG82anBx/BMCpqkCAvrTwuhb+ALT/sQsGZBWPJLqraT eMX/xyo7Jg35qFwl4ywPgR10OMxObdf+uE1n+8I9PHc2WHKNO4F9ksahYDN5PzBSLs HMZMxtkcxQJGaPJwBvd6KvWF8vZ+GPyEyOOqc4uIxArAezJt29xPGDcMsOOWa/LXHd JNRiQnsIoPaLVAkagpELHwsch3vjIlSnnlzYs2wLbff8RV6s3Q2zaPsk+1M2LLKd1v NyCwTwJh/qpgw== Date: Thu, 7 May 2026 17:26:41 +0800 From: Nathan Chancellor To: Rob Herring Cc: Daniel Golle , Krzysztof Kozlowski , Conor Dooley , Nicolas Schier , Saravana Kannan , Miguel Ojeda , Masahiro Yamada , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Tamir Duberstein , Steven Rostedt , Guenter Roeck , Aleksander Jan Bajkowski , Test User , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH v2 2/3] dt-bindings: wire style checker into dt_binding_check Message-ID: <20260507092641.GA1785345@ax162> References: <20260506184447.GA2816439-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260506184447.GA2816439-robh@kernel.org> On Wed, May 06, 2026 at 01:44:47PM -0500, Rob Herring wrote: > On Wed, Apr 29, 2026 at 03:21:33PM +0100, Daniel Golle wrote: > > diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile > > index 7b668f7fd400..35ddd0b7a349 100644 > > --- a/Documentation/devicetree/bindings/Makefile > > +++ b/Documentation/devicetree/bindings/Makefile > > @@ -46,6 +46,19 @@ quiet_cmd_chk_bindings = CHKDT $(src) > > xargs -n200 -P$$(nproc) $(DT_DOC_CHECKER) -u $(src)) \ > > && touch $@ || true > > > > +DT_CHK_STYLE = $(srctree)/scripts/dtc/dt-check-style > > + > > +# Feed the file list to the checker via @argfile in a single Python > > +# process so the ruamel.yaml import is paid once. scripts/jobserver-exec > > +# claims slots from the GNU make jobserver and exposes the count via > > +# $PARALLELISM, which dt-check-style picks up to size its worker pool. > > +quiet_cmd_chk_style = STYLE $(src) > > + cmd_chk_style = f=$$(mktemp) && $(find_cmd) > $$f && \ > > + $(PYTHON3) $(srctree)/scripts/jobserver-exec \ > > + $(PYTHON3) $(DT_CHK_STYLE) @$$f; \ > > What's the reason to run via PYTHON3 vs. running dt-check-style > directly? It's just different from the rest of this makefile. In general, scripts should be called with an explicit interpreter to 1. not rely on the file being executable (I think quilt has issues with this at times?) 2. respect the user's choice of interpreter (if they have specified one) See "Script invocation" in Documentation/kbuild/makefiles.rst. -- Cheers, Nathan