Devicetree
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"magnus.damm" <magnus.damm@gmail.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/4] dt-bindings: display: renesas,rzg2l-du: Add RZ/T2H and RZ/N2H support
Date: Thu, 7 May 2026 13:38:30 +0300	[thread overview]
Message-ID: <20260507103830.GM1778786@killaraus.ideasonboard.com> (raw)
In-Reply-To: <TY3PR01MB1134676FA7479724BDCE40649863C2@TY3PR01MB11346.jpnprd01.prod.outlook.com>

On Thu, May 07, 2026 at 09:24:48AM +0000, Biju Das wrote:
> On 06 May 2026 20:58, Lad, Prabhakar wrote:
> > On Wed, May 6, 2026 at 8:50 PM Laurent Pinchart wrote:
> > > On Wed, Apr 29, 2026 at 06:00:09PM +0100, Prabhakar wrote:
> > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > >
> > > > Document the Display Unit (DU) support for the RZ/T2H and RZ/N2H SoCs.
> > > >
> > > > The DU block on RZ/T2H is functionally equivalent to the RZ/G2UL DU
> > > > and supports the DPI interface, but includes SoC-specific register differences.
> > > > Add a dedicated compatible string to represent this variant.
> > > >
> > > > As the DU implementation on RZ/N2H matches RZ/T2H, describe it using
> > > > an RZ/N2H specific compatible string with the RZ/T2H compatible as fallback.
> > > >
> > > > Unlike other DU variants which use a multi-port model, the RZ/T2H
> > > > and RZ/N2H DU has a single output and is modelled using a single
> > > > port node with one endpoint. Add a port property to support this and
> > > > update the allOf constraints accordingly.
> > >
> > > Wouldn't it be simpler to always have a "ports" node, even for
> > > variants with a single port ?
> > >
> > I agree that, from a binding perspective, always having a "ports" node keeps things simpler and
> > consistent. Biju suggested this change based on earlier feedback for the RZ/G3E series.
> 
> From G3E feedback, I got the impression that going forward all future SoCs needs to have
> single port and multiple endpoints. That is the reason for suggesting port for new SoCs.

Right, let's clarify that.

TL;DR: it depends on the hardware architecture (what a surprise :-))

When reviewing the G3E, I noticed that the LCDC has a single output that
is connected to one or multiple encoders, depending on the SoC. I think
this should be modeled in DT with a single port.

Note that this does not preclude using a "ports" node, containing a
single "port@0". If you're confident enough that no future generation
will require multiple ports, then it makes sense to standardize on a
single "port" node and no "ports". If, on the other hand, you think that
some SoCs would have multiple ports, then using a top-level "ports" node
unconditionally would lead to simpler bindings.

I'll let you all decide what you think is the most suitable approach.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2026-05-07 10:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 17:00 [PATCH 0/4] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-04-29 17:00 ` [PATCH 1/4] dt-bindings: display: renesas,rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-06 19:43   ` Rob Herring (Arm)
2026-05-06 19:50   ` Laurent Pinchart
2026-05-06 19:58     ` Lad, Prabhakar
2026-05-07  9:24       ` Biju Das
2026-05-07 10:38         ` Laurent Pinchart [this message]
2026-05-07 10:54           ` Biju Das
2026-05-07 16:22             ` Lad, Prabhakar
2026-04-29 17:00 ` [PATCH 2/4] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-06 20:08   ` Laurent Pinchart
2026-05-07 16:25     ` Lad, Prabhakar
2026-04-29 17:00 ` [PATCH 3/4] drm: renesas: rz-du: Move mode_valid logic to per-SoC clock limits Prabhakar
2026-05-06 20:14   ` Laurent Pinchart
2026-05-08 10:00     ` Lad, Prabhakar
2026-05-08 11:23       ` Laurent Pinchart
2026-04-29 17:00 ` [PATCH 4/4] drm: renesas: rz-du: Add support for RZ/T2H SoC Prabhakar
2026-04-30  7:48   ` Geert Uytterhoeven
2026-04-30  8:28     ` Lad, Prabhakar
2026-05-06 20:17   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507103830.GM1778786@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=magnus.damm@gmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tommaso.merciai.xr@bp.renesas.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox