From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m3268.qiye.163.com (mail-m3268.qiye.163.com [220.197.32.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00DB6255E43; Thu, 7 May 2026 12:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778155544; cv=none; b=IBjGqqs18GUO3pnAy7O9cahgLuD24DGyLb5fiRO5cbBpebQz+dt1h0I0825upa5XmZ5S1tlmDcmRUs75Bmr61WEf0xpFutZ5Lcs8AFuArGcrQGmONLudpaxMzS+GsNCiZtn4qYqasZrJl7YVWcZB/GczZ54Uzyc1rm1FhXHx5ZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778155544; c=relaxed/simple; bh=IwJVK68aKk1VRyL15OhZbZLq+o8a8wmN5QrYbvGNGCo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SZ/kPWZUPMTqhldwGnGRdbo5fG5ZSgYfaXPp/0DjcI4OWZnIORviEYKoipm21xp3CFqpHhF05ylxqJzuM9UHzZDQOlxNblkCnRn2s1skJZNhlx/4ESzSezNxbWrEWBswSdEbPnxHENso7DZCX5DRj+6y6PYeVzP3ZWgSz66XEjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=f6FZdbLq; arc=none smtp.client-ip=220.197.32.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="f6FZdbLq" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 3d7b63a4c; Thu, 7 May 2026 19:30:02 +0800 (GMT+08:00) From: Damon Ding To: hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, nicolas.frattaroli@collabora.com, cristian.ciocaltea@collabora.com, sebastian.reichel@collabora.com, dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com, dianders@chromium.org, m.szyprowski@samsung.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Damon Ding Subject: [PATCH v3 05/10] drm/rockchip: analogix_dp: Enable clock "hclk" for RK3588 Date: Thu, 7 May 2026 19:29:43 +0800 Message-Id: <20260507112948.1115003-6-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260507112948.1115003-1-damon.ding@rock-chips.com> References: <20260507112948.1115003-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9e0233b18903a3kunm4d1cbcd726b3 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVkZSh0ZVh0eGUxJHhkeSx9DTFYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSE pKQk1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=f6FZdbLqQ+FWHRE5yxNpnNydjhkqy0kEE4FbM2iM6Sfi7N1A6IcdaihiE1iBy6hiuwdVTujLbflzJ7orc4y9iZJlUWCNoMpE1FC4Do7hAI/PuhPCM1kt3G4E7i2h6q9py79F4PNkzjmS8cThyMbmghxXNPTBWmqj8uHBJeAp5YQ=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=K5FWFqjXi+9fA66qQ0uxSff9rdNwbwOqNuO4OlZthhw=; h=date:mime-version:subject:message-id:from; The RK3588 eDP controller needs the video datapath clock "hclk" to work well. Previously, it works without explicitly adding this clock because the 'rockchip,vo-grf = <&vo1_grf>' property implicitly enables HCLK_VO1. Fixes: 729f8eefdcad ("drm/rockchip: analogix_dp: Add support for RK3588") Signed-off-by: Damon Ding --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index 41ff44eaf44d..a864bcf8200e 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -311,6 +311,7 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp) { struct device *dev = dp->dev; struct device_node *np = dev->of_node; + struct clk *clk; dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf"); if (IS_ERR(dp->grf)) @@ -327,6 +328,11 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp) return dev_err_probe(dev, PTR_ERR(dp->pclk), "failed to get pclk property\n"); + clk = devm_clk_get_optional_enabled(dev, "hclk"); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to get hclk property\n"); + dp->rst = devm_reset_control_get(dev, "dp"); if (IS_ERR(dp->rst)) return dev_err_probe(dev, PTR_ERR(dp->rst), -- 2.34.1