Devicetree
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Chaitanya Sabnis <chaitanya.msabnis@gmail.com>
Cc: andi.shyti@kernel.org, wsa@kernel.org, anders.berg@lsi.com,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: convert axxia i2c to dt-schema
Date: Thu, 7 May 2026 14:29:23 -0500	[thread overview]
Message-ID: <20260507192923.GA2429305-robh@kernel.org> (raw)
In-Reply-To: <20260505100854.5258-1-chaitanya.msabnis@gmail.com>

On Tue, May 05, 2026 at 03:38:54PM +0530, Chaitanya Sabnis wrote:
> Convert the LSI Axxia I2C Controller bindings from legacy text
> format to modern dt-schema (YAML).
> 
> During the conversion, the obsolete `device_type = "i2c"` property
> was dropped from the example, as it is deprecated and not utilized
> by the driver. The `clock-names` property is enforced as required
> matching the driver probe behavior. The example node address was
> also updated to a standard 32-bit address.
> 
> Signed-off-by: Chaitanya Sabnis <chaitanya.msabnis@gmail.com>
> ---
>  .../devicetree/bindings/i2c/i2c-axxia.txt     | 30 -----------
>  .../devicetree/bindings/i2c/lsi,api2c.yaml    | 52 +++++++++++++++++++
>  2 files changed, 52 insertions(+), 30 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-axxia.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-axxia.txt b/Documentation/devicetree/bindings/i2c/i2c-axxia.txt
> deleted file mode 100644
> index 7d53a2b79553..000000000000
> --- a/Documentation/devicetree/bindings/i2c/i2c-axxia.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -LSI Axxia I2C
> -
> -Required properties :
> -- compatible : Must be "lsi,api2c"
> -- reg : Offset and length of the register set for the device
> -- interrupts : the interrupt specifier
> -- #address-cells : Must be <1>;
> -- #size-cells : Must be <0>;
> -- clock-names : Must contain "i2c".
> -- clocks: Must contain an entry for each name in clock-names. See the common
> -  clock bindings.
> -
> -Optional properties :
> -- clock-frequency : Desired I2C bus clock frequency in Hz. If not specified,
> -  the default 100 kHz frequency will be used. As only Normal and Fast modes
> -  are supported, possible values are 100000 and 400000.
> -
> -Example :
> -
> -i2c@2010084000 {
> -	compatible = "lsi,api2c";
> -	device_type = "i2c";
> -	#address-cells = <1>;
> -	#size-cells = <0>;
> -	reg = <0x20 0x10084000 0x00 0x1000>;
> -	interrupts = <0 19 4>;
> -	clocks = <&clk_per>;
> -	clock-names = "i2c";
> -	clock-frequency = <400000>;
> -};
> diff --git a/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml b/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
> new file mode 100644
> index 000000000000..2d1c3069c3a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/lsi,api2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LSI Axxia I2C Controller
> +
> +maintainers:
> +  - Anders Berg <anders.berg@lsi.com>

I don't think lsi.com is valid any more. We'll see if it bounces. 
Otherwise,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

      reply	other threads:[~2026-05-07 19:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05 10:08 [PATCH] dt-bindings: i2c: convert axxia i2c to dt-schema Chaitanya Sabnis
2026-05-07 19:29 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507192923.GA2429305-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=anders.berg@lsi.com \
    --cc=andi.shyti@kernel.org \
    --cc=chaitanya.msabnis@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox