Re: [PATCH v2 2/8] dt-bindings: net: wireless: qcom,ath10k: Add NVMEM MAC address cell

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch defines `nvmem-cells: maxItems: 1` and `nvmem-cell-names: const: mac-address`, which explicitly invalidates and prevents valid device tree configurations that use NVMEM for calibration data.
--

commit fb9ea9036c91c7c939b039f47a6a36361ae2f2fe
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>

dt-bindings: net: wireless: qcom,ath10k: Add NVMEM MAC address cell

This commit adds support for an NVMEM cell provider with the standard
mac-address cell name to allow ath10k to retrieve its MAC address from
non-volatile storage.

> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml

[ ... ]

> @@ -92,6 +92,15 @@ properties:
>  
>    ieee80211-freq-limit: true
>  
> +  nvmem-cells:
> +    maxItems: 1
> +    description:
> +      Nvmem data cell that contains a 6 byte MAC address with the most
> +      significant byte first (big-endian).
> +
> +  nvmem-cell-names:
> +    const: mac-address

Does this restrict the binding to only allow a single NVMEM cell, and
force its name to be exactly mac-address?

The ath10k driver natively fetches NVMEM calibration data via cells named
calibration and pre-calibration (see ath10k_download_cal_nvmem() in
drivers/net/wireless/ath/ath10k/core.c).

Existing upstream device trees, such as
arch/arm/boot/dts/qcom/qcom-ipq4018-ap120c-ac.dtsi, actively define
nvmem-cell-names = "pre-calibration" for ath10k nodes.

Would setting maxItems to 1 and restricting the name to mac-address
prevent a device from defining both a MAC address and calibration data
simultaneously, and cause dtbs_check validation failures for existing
hardware configurations?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260507-block-as-nvmem-v2-0-bf17edd5134e@oss.qualcomm.com?part=2