Re: [PATCH v2 4/4] mailbox: qcom-apcs-ipc: Add Shikra APCS IPC support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds a new compatible string `qcom,shikra-apss-shared` that reuses existing driver data (`apps_shared_apcs_data`), directly violating an explicit maintainer directive in the code.
--

commit 6670ebc79f6a6772d5ca45315526be52e226e375
Author: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>

mailbox: qcom-apcs-ipc: Add Shikra APCS IPC support

This commit enables Shikra APCS IPC support by adding the compatible string.
It reuses the existing apps_shared_apcs_data.

> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index d3a8f6b4a03b3..25f76965921ba 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -168,6 +168,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
>  	{ .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq6018_apcs_data },
>  	{ .compatible = "qcom,sc7180-apss-shared", .data = &apps_shared_apcs_data },
>  	{ .compatible = "qcom,sc8180x-apss-shared", .data = &apps_shared_apcs_data },
> +	{ .compatible = "qcom,shikra-apss-shared", .data = &apps_shared_apcs_data },

This isn't a bug, but does this addition conflict with the maintainer comment
located earlier in the qcom_apcs_ipc_of_match array?

The array contains an explicit directive:
/* Do not add any more entries using existing driver data */

Should this new device instead use a fallback compatible string in the
devicetree, such as "qcom,shikra-apss-shared", "qcom,sdm845-apss-shared",
rather than expanding the driver's match table?

>  	{ .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
>  	{}
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-shikra_mailbox_and_rpm_changes-v2-0-ab76fd9e71de@oss.qualcomm.com?part=4