Re: [PATCH 2/3] dt-bindings: interrupt-controller: Add support for Amlogic A9 SoCs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Nesting an `if/then/else` block directly under an `else` keyword violates the standard dt-bindings schema architecture for handling multiple conditionals.
- [Low] The schema description block was not updated to reflect the newly added hardware capabilities of up to 20 interrupt channels.
--

commit b693f66cbc7c3dca220bdaf6db2d2cc269158d23
Author: Xianwei Zhao <xianwei.zhao@amlogic.com>

dt-bindings: interrupt-controller: Add support for Amlogic A9 SoCs

This commit updates the Amlogic Meson GPIO interrupt controller binding to
support Amlogic A9 SoCs. It adds the new compatible strings and increases the
maximum allowed channel interrupts to 20 for the new hardware variants.

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
> index d0fad930de9d9..d26671913e895 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml

[ ... ]

> @@ -56,7 +58,7 @@ properties:
>    amlogic,channel-interrupts:
>      description: Array with the upstream hwirq numbers
>      minItems: 2
> -    maxItems: 12
> +    maxItems: 20

Since the maximum number of channel interrupts is increased to 20 here, should
the description block at the top of the schema file be updated as well? 

It currently states the hardware is "essentially a 256 pads to 8 or 12 GIC
interrupt multiplexer".

[ ... ]

> @@ -76,9 +78,20 @@ then:
>      amlogic,channel-interrupts:
>        maxItems: 2
>  else:
> -  properties:
> -    amlogic,channel-interrupts:
> -      minItems: 8
> +  if:
> +    properties:
> +      compatible:
> +        contains:
> +          const: amlogic,a9-gpio-ao-intc

This isn't a bug, but does this structure follow the standard dt-bindings
schema architecture for handling multiple conditionals?

The bindings documentation typically suggests grouping multiple if schemas
under a top-level allOf array, rather than nesting an if block directly under
an else keyword.

> +  then:
> +    properties:
> +      amlogic,channel-interrupts:
> +        minItems: 20
> +  else:
> +    properties:
> +      amlogic,channel-interrupts:
> +        minItems: 8
> +        maxItems: 12

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-a9-gpio-irqchip-v1-0-9dc5f3e022e0@amlogic.com?part=2