Re: [PATCH v5 1/3] dt-bindings: trivial-devices: Add Delta E50SN12051

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string and its description comment are inserted incorrectly, resulting in mismatched descriptions for two devices.
--

commit 9996702d5ece9eeefae380c70a0a1d77e2a9cf5a
Author: Colin Huang <u8813345@gmail.com>

dt-bindings: trivial-devices: Add Delta E50SN12051
    
This commit adds the Delta E50SN12051 600W Non-isolated 1/8th Brick DC/DC
Power Module to the list of trivial devices.

> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 23fd4513933a4..0f10368a13865 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -100,6 +100,8 @@ properties:
>              # Delta Electronics DPS920AB 920W 54V Power Supply
>            - delta,dps920ab
>              # 1/4 Brick DC/DC Regulated Power Module
> +          - delta,e50sn12051
> +            # 600W Non-isolated 1/8th Brick DC/DC Power Modules
>            - delta,q54sj108a2

This isn't a bug, but it looks like the comment and the compatible string
are inserted in the wrong order. In this file, comments describe the
compatible string that immediately follows them.

By inserting the new string before the new comment, the existing "1/4 Brick"
comment now appears to describe the new delta,e50sn12051 string, and the new
"600W" comment describes the existing delta,q54sj108a2 string. 

Should the new comment be placed above delta,e50sn12051 instead to keep the
descriptions aligned with their respective devices?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-add-e50sn12051-v5-0-abebdcc29665@gmail.com?part=1