From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F4003351C20 for ; Fri, 8 May 2026 19:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778269853; cv=none; b=TGtvSN8xLVkOXE9HyemKuHI/wBDm8tJGlFfg9ODlGDkEjHqUIc/n+2fCmiatdGBaoqQPYfDwyvMDFLB1C8oiVuWQFSnB6LSBerE3fKWCO4vlRlFXwoNjNL/KX2h7y2VovAKfu+KZJA7Q+BLl1wfFGpvV6hq/ZcWsgdbxMdOIbws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778269853; c=relaxed/simple; bh=K8yh5eCvv6u1tBg/BnZudTFfkZF0wM+MB9VW71nkoS4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=mVBqqYhMcsk9Uy4IrfZwWJtMFowb5vy5hTNbFHgMxanlZenGFATYKRhbFniZDTFe6775cwOOkEC+IR6gy2bFSpvIra1OPBv7fDJeAWxVo7Bw+NiSD4Kl8TBaLmjFe9VTQ0rf0pLJUn5pYSSLW303cIUA7M5o4zx5I3ddLxZOTIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XkoEay/n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XkoEay/n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 600D3C2BCB0; Fri, 8 May 2026 19:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778269852; bh=K8yh5eCvv6u1tBg/BnZudTFfkZF0wM+MB9VW71nkoS4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=XkoEay/n+VBzHzlfxLGRJDDp8alOEyEXNaxZLAZp6wsoyQ9Laf6VouyCWzNbeAPCQ UKXiZP7VFZHwBZw5prZ+Tf/Z638dbS+Ws5B4gk/ztyUAEgauLn8g4ezLKDb4mpYfnt ECWLqyoTFjzkaVzyvhoLBrcAydvqNfxOVxfBLATqZj20iWnX5bFudaKVH+ejclzQsf AXdbq6z8oYkhoQiTUjl9w7wRyio6NlKj9JQQKX0ep+mWxuW76LXhTHXfHRjUY2AH7h ODCoV3QhibCHPshCqQuCIe8LaRMWoBZnvUkO6QBOyapC3QzlUzS4oNsqKuLXAFC/Bb o5xRqniitn0SA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: kaanapali: Add camera MCLK pinctrl Reply-To: sashiko@lists.linux.dev To: "Hangxiang Ma" Cc: devicetree@vger.kernel.org, krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20260508-knp-camera-v1-3-a18e289163fd@oss.qualcomm.com> References: <20260508-knp-camera-v1-3-a18e289163fd@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 08 May 2026 19:50:51 +0000 Message-Id: <20260508195052.600D3C2BCB0@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Incomplete Power Management: Missing 'sleep' states for camera M= CLK pinctrls. -- commit 3df184e361a5c8fe5a2bf34fc4785990c54c8020 Author: Hangxiang Ma arm64: dts: qcom: kaanapali: Add camera MCLK pinctrl This commit defines pinctrl definitions to enable camera master clocks on t= he Kaanapali platform. > diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dt= s/qcom/kaanapali.dtsi > --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi > +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi [ ... ] > @@ -3903,6 +3903,62 @@ tlmm: pinctrl@f100000 { > #interrupt-cells =3D <2>; > wakeup-parent =3D <&pdc>; > =20 > + cam0_default: cam0-default-state { > + pins =3D "gpio89"; > + function =3D "cam_mclk"; > + drive-strength =3D <2>; > + bias-disable; > + }; Should there also be corresponding sleep states defined for these MCLK pins? Typically on Qualcomm platforms, camera sensor drivers request both default and sleep states. The sleep state safely parks the pad, usually via bias-pull-down, when the camera is powered off. Without a sleep state, the MCLK pins might be left floating when powered off due to the bias-disable setting here, which could cause power leakage. Other camera pins in the Kaanapali device tree seem to follow the pattern of havi= ng sleep states defined. [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260508-knp-camera= -v1-0-a18e289163fd@oss.qualcomm.com?part=3D3