Re: [PATCH v2 2/2] riscv: dts: thead: Enable WiFi on Lichee Pi 4A

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `&sdio1` node specifies `#address-cells = <1>;` and `#size-cells = <0>;` but contains no child nodes.
--

commit 89c378a34273e40ecc4c5313fff87bf9f739222c
Author: MoeLeak <i@leak.moe>

riscv: dts: thead: Enable WiFi on Lichee Pi 4A

This commit enables the RTL8723DS WiFi module on the Lichee Pi 4A. It
configures the SDIO1 controller and sets up the I2C1 bus for the GPIO
expander used to drive the module reset line.

> diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> index 7cb7d28683bce..af6f25ebbf607 100644
> --- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts

[ ... ]

> @@ -132,6 +153,32 @@ rx-pins {
>  	};
>  };
>  

[ ... ]

> +&sdio1 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;

This isn't a bug, but since this node does not contain any child nodes,
will including #address-cells and #size-cells trigger the dtc compiler
warning for avoid_unnecessary_addr_size?

Should these properties be removed if no child node is being explicitly
added for the WiFi module?

> +	bus-width = <4>;
> +	max-frequency = <198000000>;
> +	cap-sdio-irq;
> +	keep-power-in-suspend;
> +	mmc-pwrseq = <&wifi_pwrseq>;
> +	non-removable;
> +	status = "okay";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-lichee-pi-4a-wifi-v2-0-7acf63559e62@leak.moe?part=2