From: sashiko-bot@kernel.org
To: "Hungyu Lin" <dennylin0707@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding
Date: Fri, 08 May 2026 23:50:14 +0000 [thread overview]
Message-ID: <20260508235015.3B10FC2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260508233730.77834-1-dennylin0707@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing reference to standard SPI peripheral properties schema restricts valid SPI configurations.
--
commit 05158b905a98b93285ae76fe23056051bd698d9e
Author: Hungyu Lin <dennylin0707@gmail.com>
dt-bindings: iio: dds: Add AD9832/AD9835 binding
This commit adds device tree binding documentation for the AD9832 and
AD9835 SPI-controlled direct digital synthesizers.
> diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
[ ... ]
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - avdd-supply
> + - dvdd-supply
> +
> +unevaluatedProperties: false
Does this binding need a reference to the standard SPI peripheral properties
schema?
Since unevaluatedProperties is set to false without including a reference to
/schemas/spi/spi-peripheral-props.yaml#, standard SPI properties provided by
a board's device tree (such as spi-cpol, spi-cpha, spi-cs-high, or
spi-rx-delay-us) will be incorrectly rejected by dtbs_check.
Should this schema include an allOf block to inherit the common SPI
properties so that different board designs and controller requirements can
be correctly evaluated?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260508233730.77834-1-dennylin0707@gmail.com?part=1
next prev parent reply other threads:[~2026-05-08 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 23:37 [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding Hungyu Lin
2026-05-08 23:50 ` sashiko-bot [this message]
2026-05-09 16:00 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508235015.3B10FC2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dennylin0707@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox