Re: [PATCH v7 10/10] arm64: dts: realtek: Add clock support for RTD1625

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Device tree nodes with a unit-address should be ordered by their physical unit-address, but `clock-controller@7088` is incorrectly placed after `serial@7800`.
- [Low] The fixed-clock node is named `osc`, which uses a deprecated naming format according to the `fixed-clock` bindings.
--

commit a60494898a192c94263b0fcf9833b624f1fce48f
Author: Yu-Chun Lin <eleanor.lin@realtek.com>

arm64: dts: realtek: Add clock support for RTD1625

This commit adds the clock controller nodes and an osc27m fixed clock for
the Realtek RTD1625 SoC to the kent.dtsi device tree.

> diff --git a/arch/arm64/boot/dts/realtek/kent.dtsi b/arch/arm64/boot/dts/realtek/kent.dtsi
> index ae006ce244205..4722337a143d8 100644
> --- a/arch/arm64/boot/dts/realtek/kent.dtsi
> +++ b/arch/arm64/boot/dts/realtek/kent.dtsi
> @@ -26,6 +26,15 @@ timer {
>  			     <GIC_PPI  9 IRQ_TYPE_LEVEL_HIGH>;
>  	};
>  
> +	clocks {
> +		osc27m: osc {

This isn't a bug, but does the node name osc follow the fixed-clock bindings?
The fixed-clock schema deprecates generic names like osc and prefers names
matching the clock-([0-9]+|[a-z0-9-]+) pattern, such as clock-27000000.

> +			compatible = "fixed-clock";
> +			clock-frequency = <27000000>;
> +			clock-output-names = "osc27m";
> +			#clock-cells = <0>;
> +		};
> +	};
> +

[ ... ]

>  			uart0: serial@7800 {
>  				compatible = "snps,dw-apb-uart";
>  				reg = <0x7800 0x100>;
> @@ -150,6 +167,22 @@ uart0: serial@7800 {
>  				reg-shift = <2>;
>  				status = "disabled";
>  			};
> +
> +			ic: clock-controller@7088 {

This isn't a bug, but should clock-controller@7088 be placed before
serial@7800? Device tree nodes with unit-addresses are typically sorted in
ascending order by their physical address.

> +				compatible = "realtek,rtd1625-iso-clk";
> +				reg = <0x7088 0x8>;
> +				clocks = <&osc27m>;
> +				#clock-cells = <1>;
> +				#reset-cells = <1>;
> +			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508111641.3192177-1-eleanor.lin@realtek.com?part=10