From: sashiko-bot@kernel.org
To: "Judith Mendez" <jm@ti.com>
Cc: devicetree@vger.kernel.org, krzk+dt@kernel.org, robh@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v2 3/3] arm64: defconfig: Enable drivers for BeagleBadge
Date: Fri, 08 May 2026 23:59:33 +0000 [thread overview]
Message-ID: <20260508235934.1EF3DC2BCB4@smtp.kernel.org> (raw)
In-Reply-To: <20260508230341.1891450-4-jm@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added configurations `CONFIG_SENSORS_SHT4x` and `CONFIG_LEDS_PWM_MULTICOLOR` are not placed in the correct `savedefconfig` sequence.
--
commit 6f7a4afa4cd800dc21fa4233eabb09b5e3390bc1
Author: Judith Mendez <jm@ti.com>
arm64: defconfig: Enable drivers for BeagleBadge
This commit enables several drivers as modules or built-in for the
BeagleBadge device. The enabled drivers include LED PWM Multicolor, MCP SPI
IO Expander, Seven Segment display GPIO, and Temperature Sensor.
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d905a0777f939..0e4cf5e01146f 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
[ ... ]
> @@ -764,6 +765,7 @@ CONFIG_SENSORS_MACSMC_HWMON=m
> CONFIG_SENSORS_LM75=m
> CONFIG_SENSORS_LM90=m
> CONFIG_SENSORS_PWM_FAN=m
> +CONFIG_SENSORS_SHT4x=m
This isn't a bug, but was this defconfig updated using make savedefconfig?
Manual insertions can disrupt the canonical Kconfig parsing order. Based on
the definitions in drivers/hwmon/Kconfig, SENSORS_SHT4x is defined after
SENSORS_SL28CPLD and before SENSORS_AMC6821, so its proper canonical
placement would be between those two entries.
> CONFIG_SENSORS_RASPBERRYPI_HWMON=m
> CONFIG_SENSORS_SL28CPLD=m
> CONFIG_SENSORS_AMC6821=m
[ ... ]
> @@ -1333,6 +1337,7 @@ CONFIG_LEDS_PWM=y
> CONFIG_LEDS_SYSCON=y
> CONFIG_LEDS_QCOM_FLASH=m
> CONFIG_LEDS_QCOM_LPG=m
> +CONFIG_LEDS_PWM_MULTICOLOR=m
Similarly, should CONFIG_LEDS_PWM_MULTICOLOR precede CONFIG_LEDS_QCOM_LPG
to match the order in drivers/leds/rgb/Kconfig?
> CONFIG_LEDS_TRIGGER_TIMER=y
> CONFIG_LEDS_TRIGGER_DISK=y
> CONFIG_LEDS_TRIGGER_HEARTBEAT=y
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260508230341.1891450-1-jm@ti.com?part=3
prev parent reply other threads:[~2026-05-08 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 23:03 [PATCH v2 0/3] arm64: dts/bindings: Add support for BeagleBadge Judith Mendez
2026-05-08 23:03 ` [PATCH v2 1/3] dt-bindings: arm: ti: Add am62l3-beaglebadge Judith Mendez
2026-05-08 23:03 ` [PATCH v2 2/3] arm64: dts: ti: Add k3-am62l3-beaglebadge Judith Mendez
2026-05-08 23:46 ` sashiko-bot
2026-05-08 23:03 ` [PATCH v2 3/3] arm64: defconfig: Enable drivers for BeagleBadge Judith Mendez
2026-05-08 23:59 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508235934.1EF3DC2BCB4@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox