Re: [PATCH] dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Incorrect regex for `patternProperties` matching channel unit addresses (expects decimal instead of hex).
- [Medium] Missing conditional schema validation for `xlnx,external-mux-channel`.
--

commit 9cb917c448e17a8e4cd03c2b0f448fe1debfc5c0
Author: Pramod Maurya <pramod.nexgen@gmail.com>

dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema

This commit converts the Xilinx XADC and UltraScale System Monitor device
tree binding from the legacy plain-text format to a YAML schema, enabling
automated validation with dt-schema.

> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
> new file mode 100644
> index 0000000000000..86bdc4920cdbf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
> @@ -0,0 +1,191 @@
[ ... ]
> +  xlnx,external-mux:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description: |
> +      Selects the external multiplexer mode.
> +    enum:
> +      - none
> +      - single
> +      - dual
> +
> +  xlnx,external-mux-channel:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Configures which pair of pins is used to sample data in external
> +      multiplexer mode. This property is required when the device is
> +      configured for external multiplexer mode.

The description mentions this property is required when the device is
configured for external multiplexer mode (e.g., when xlnx,external-mux is
set to "single" or "dual").

Should the schema enforce this dynamically using an allOf -> if/then block?

Without conditional enforcement, device trees that enable the external
multiplexer but omit the required channel configuration might silently pass
automated dt-schema validation.

[ ... ]
> +  xlnx,channels:
> +    type: object
> +    description:
> +      List of external channels connected to the ADC. If this property is
> +      absent, no external channels are assumed to be connected.
> +
> +    properties:
> +      '#address-cells':
> +        const: 1
> +
> +      '#size-cells':
> +        const: 0
> +
> +    patternProperties:
> +      "^channel@([0-9]|1[0-6])$":
> +        type: object
> +        description:

Device tree unit addresses must be formatted as lowercase hexadecimal.
A reg value of 10-15 corresponds to the unit addresses @a through @f.

Does this regex expect decimal numbers instead? If so, it might incorrectly
reject valid hexadecimal unit addresses like channel@a through channel@f,
and erroneously allow channel@16 (which corresponds to a reg of 22).

Should this regex be updated to match hex values instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260509171453.45844-1-pramod.nexgen@gmail.com?part=1