Re: [PATCH v2] dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Invalid `minimum` and `maximum` constraints applied directly to the `reg` property in `channel@...` subnodes.
--

commit 5043f94915e880a0ca171308ea2b8d199810b756
Author: Pramod Maurya <pramod.nexgen@gmail.com>

dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema

This commit converts the Xilinx XADC and UltraScale System Monitor device
tree binding from the legacy plain-text format to a YAML schema. The
new binding covers the ZYNQ hardmacro, AXI softmacro, and UltraScale System
Management Wizard.

> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
> new file mode 100644
> index 0000000000000..cfe753e3e8d19
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml

[ ... ]

> +    patternProperties:
> +      "^channel@([0-9a-f]|10)$":
> +        type: object
> +        description:
> +          Represents an external channel connected to the ADC.
> +
> +        properties:
> +          reg:
> +            description: |
> +              Pair of pins the channel is connected to.
> +                0: VP/VN
> +                1: VAUXP[0]/VAUXN[0]
> +                2: VAUXP[1]/VAUXN[1]
> +                ...
> +                16: VAUXP[15]/VAUXN[15]
> +            minimum: 0
> +            maximum: 16

Will these constraints work correctly on the reg property?

In dt-schema, the reg property is intrinsically defined as a uint32-matrix
array type. According to the JSON Schema specification, the minimum and
maximum validation keywords apply exclusively to numeric types, not arrays.

Placing these keywords directly on the reg property may trigger a
meta-schema violation during dt_binding_check or be silently ignored,
allowing out-of-bounds configurations to pass validation.

Should this use maxItems: 1 with the numeric bounds placed inside items,
such as items: [ { minimum: 0, maximum: 16 } ] instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260509180719.53704-1-pramod.nexgen@gmail.com?part=1