Re: [PATCH v3] dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Invalid use of 'minimum' and 'maximum' directly on the 'reg' array property within the 'channel@...' subnode.
--

commit 1ceb6107e206dae61695383d0449f5edc509e233
Author: Pramod Maurya <pramod.nexgen@gmail.com>

dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema

This commit converts the legacy plain-text device tree bindings for the
Xilinx XADC and UltraScale System Monitor to the YAML schema format to
enable automated validation.

> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
[ ... ]
> +    patternProperties:
> +      "^channel@([0-9a-f]|10)$":
> +        type: object
> +        description:
> +          Represents an external channel connected to the ADC.
> +
> +        properties:
> +          reg:
> +            description: |
> +              Pair of pins the channel is connected to.
> +                0: VP/VN
> +                1: VAUXP[0]/VAUXN[0]
> +                2: VAUXP[1]/VAUXN[1]
> +                ...
> +                16: VAUXP[15]/VAUXN[15]
> +            minimum: 0
> +            maximum: 16

Are these minimum and maximum constraints taking effect as intended?

In dt-schema, the reg property is inherently typed as an array. According to
the JSON schema specification, the minimum and maximum validation keywords
apply only to numeric instances and are silently ignored when applied directly
to an array. Because of this, the intended limits on the channel values might
be bypassed during dtbs_check.

Could this be updated to specify maxItems: 1 and apply the numeric limits
inside an items constraint to ensure the correct unit address values are
strictly enforced?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260510083219.70224-1-pramod.nexgen@gmail.com?part=1