From: sashiko-bot@kernel.org
To: "Michal Piekos" <michal.piekos@mmpsystems.pl>
Cc: robh@kernel.org, devicetree@vger.kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: allwinner: a523: add gpadc node
Date: Mon, 11 May 2026 21:30:25 +0000 [thread overview]
Message-ID: <20260511213026.7F5A8C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260510-sunxi-a523-gpadc-v1-3-4f6b0f4000fb@mmpsystems.pl>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message incorrectly describes the hardware change and target SoC.
--
commit 6c12757bc070dc9476878d0e08e22e28437d957d
Author: Michal Piekos <michal.piekos@mmpsystems.pl>
arm64: dts: allwinner: a523: add gpadc node
This commit adds the General Purpose ADC node to the Allwinner A523
device tree. It also documents successful voltage testing of the ADC
channels on the Radxa Cubie A5E board.
> Describe high speed timer block on Allwinner D1S-T113.
This isn't a bug in the device tree changes, but the commit description
appears to have a copy-paste error. The text mentions a high speed timer
block on the Allwinner D1S-T113, while the patch actually adds the gpadc
node for the sun55i-a523.
Could this description be updated to accurately reflect the gpadc addition?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260510-sunxi-a523-gpadc-v1-0-4f6b0f4000fb@mmpsystems.pl?part=3
prev parent reply other threads:[~2026-05-11 21:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 12:57 [PATCH 0/3] Add GPADC support for A523 Michal Piekos
2026-05-10 12:57 ` [PATCH 1/3] dt-bindings: iio: adc: Add GPADC for Allwinner A523 Michal Piekos
2026-05-10 14:29 ` Rob Herring (Arm)
2026-05-10 14:40 ` Jernej Škrabec
2026-05-11 16:02 ` Andre Przywara
2026-05-12 3:56 ` Michal Piekos
2026-05-11 20:57 ` sashiko-bot
2026-05-10 12:57 ` [PATCH 2/3] iio: adc: sun20i-gpadc: add A523 gpadc support Michal Piekos
2026-05-11 21:15 ` sashiko-bot
2026-05-12 11:51 ` Jonathan Cameron
2026-05-12 13:48 ` Andre Przywara
2026-05-10 12:57 ` [PATCH 3/3] arm64: dts: allwinner: a523: add gpadc node Michal Piekos
2026-05-10 14:39 ` Jernej Škrabec
2026-05-10 18:34 ` Chen-Yu Tsai
2026-05-11 21:30 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511213026.7F5A8C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=michal.piekos@mmpsystems.pl \
--cc=robh@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox