Re: [RFC PATCH 1/2] dt-bindings: iio: magnetometer: add Melexis MLX90393

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The devicetree binding documents only the I2C interface for a device that supports both I2C and SPI, artificially restricting valid hardware descriptions.
- [Medium] Essential physical hardware connections, such as power supplies and interrupts, are omitted from the schema and actively forbidden by `additionalProperties: false`.
--

commit 8e952d4236837623faf2f1c5e7d285f977fcfe5a
Author: Nikhil Gautam <nikhilgtr@gmail.com>

dt-bindings: iio: magnetometer: add Melexis MLX90393

This commit adds devicetree bindings for the Melexis MLX90393 3-axis
magnetometer and temperature sensor. It currently documents the I2C
interface for the device.

> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml b/Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml
> new file mode 100644
> index 0000000000000..b99629ff25855
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml
[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - melexis,mlx90393
> +
> +  reg:
> +    maxItems: 1

Are essential physical hardware connections, such as power supplies
(vdd-supply, vddio-supply) and optional interrupt pins missing here?

Because the schema enforces additionalProperties: false, any downstream board
devicetree that accurately models these physical connections to regulators or
interrupt controllers will fail schema validation. Could these properties be
explicitly listed to permit complete hardware descriptions, even if the
current driver does not yet use them?

> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

Does this artificially restrict valid hardware descriptions by omitting the
SPI interface?

The commit message and subsequent driver commit (iio: magnetometer: add
support for Melexis MLX90393) explicitly state that the MLX90393 hardware
supports both I2C and SPI interfaces. However, the schema enforces
additionalProperties: false without referencing standard SPI properties like
spi-max-frequency.

Consequently, any valid board devicetree that connects the device via an
SPI bus will fail dtbs_check validation. Should the binding describe the
hardware component's full capabilities rather than just the limits of the
initial driver implementation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260510191010.155380-1-nikhilgtr@gmail.com?part=1