Re: [PATCH v12 05/11] iio: core: add decimal value formatting into 64-bit value

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Format specifier `*` in `sysfs_emit_at` expects an `int` argument, but an `unsigned int` is provided.
--

commit b6e4aabfddeab683c1c7680ea9a056d0b185ccd2
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

iio: core: add decimal value formatting into 64-bit value

This commit introduces new IIO format types to represent fixed decimal point
values as single 64-bit numbers. It also adds helpers for composing and
decomposing these values and updates the parsing logic to use kstrtodec64().

> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c

[ ... ]

> @@ -707,8 +707,25 @@ static ssize_t __iio_format_value(char *buf, size_t offset, unsigned int type,
>  	case IIO_VAL_CHAR:
>  		return sysfs_emit_at(buf, offset, "%c", (char)vals[0]);
>  	case IIO_VAL_INT_64:
> -		tmp2 = (s64)((((u64)vals[1]) << 32) | (u32)vals[0]);
> +		tmp2 = iio_val_s64_from_array(vals);
>  		return sysfs_emit_at(buf, offset, "%lld", tmp2);
> +	case IIO_VAL_DECIMAL64_MILLI:
> +	case IIO_VAL_DECIMAL64_MICRO:
> +	case IIO_VAL_DECIMAL64_NANO:
> +	case IIO_VAL_DECIMAL64_PICO:
> +	{
> +		s64 frac;
> +		unsigned int scale = type - IIO_VAL_DECIMAL64_BASE;
> +
> +		tmp2 = div64_s64_rem(iio_val_s64_from_array(vals),
> +				     int_pow(10, scale), &frac);
> +		if (tmp2 == 0 && frac < 0)
> +			return sysfs_emit_at(buf, offset, "-0.%0*lld", scale,
> +					     abs(frac));
> +		else
> +			return sysfs_emit_at(buf, offset, "%lld.%0*lld", tmp2,
> +					     scale, abs(frac));

Does passing the unsigned int scale to the * format specifier cause a
compiler warning?

The * width specifier expects an argument of type int.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260510-adf41513-iio-driver-v12-0-34af2ed2779f@analog.com?part=5