Re: [PATCH v2 2/3] dt-bindings: usb: add Rohm BM92TXX Type-C controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] Missing type definitions and non-standard unit suffix for `rohm,pd-*v-current-limit-ma`.
- [Low] Invalid Devicetree property naming with underscores (`pd_bat_chg-supply`).
- [Low] Use of deprecated singular GPIO property suffix (`rohm,vconn-en-gpio`).
--

commit 482fd67d1e5e9ceafc592495c4e2a23d21e35b0e
Author: Alexandre Hamamdjian <azkali.limited@gmail.com>

dt-bindings: usb: add Rohm BM92TXX Type-C controller

Add the device-tree binding documentation for the Rohm BM92TXX family
of USB Type-C and Power Delivery controllers.

> diff --git a/Documentation/devicetree/bindings/usb/rohm,bm92t.yaml b/Documentation/devicetree/bindings/usb/rohm,bm92t.yaml
> new file mode 100644
> index 0000000000000..007f70a8f5bb1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/rohm,bm92t.yaml

[ ... ]

> +  vbus-source-supply:
> +    description: VBUS source (provider) regulator.
> +
> +  pd_bat_chg-supply:
> +    description: Battery charger regulator gated by Power Delivery state.

Does this property name violate Devicetree naming conventions? Devicetree
properties typically use hyphens instead of underscores (e.g.,
pd-bat-chg-supply).

> +
> +  rohm,vconn-en-gpio:
> +    maxItems: 1
> +    description: GPIO controlling the external VCONN switch.

Should this property use the standard -gpios suffix? Even for a single GPIO
line, the standard suffix is -gpios rather than the deprecated -gpio.

[ ... ]

> +  rohm,dock-power-limit-disable:
> +    type: boolean
> +    description:
> +      Disable the lower power limit applied when a dock is detected.
> +
> +  rohm,pd-5v-current-limit-ma:
> +    description: Charging current limit in mA when 5V PD contract is active.

Does this property lack an explicit type definition? Custom properties without
standard unit suffixes require a type reference, otherwise schema validation
will fail for integer array values. Also, the -ma suffix is not a standard
unit suffix (such as -milliamp or -microamp).

I see this schema validation failure is fixed later in the series by commit
315ea48f16e75d9fc77bc6e2af87cacc47b7249f ("dt-bindings: usb: fix properties
type").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-bm92t-v2-0-2145e4f4386b@gmail.com?part=2