From: sashiko-bot@kernel.org
To: "Kathiravan Thirumoorthy" <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: ipq5210: add watchdog node
Date: Tue, 12 May 2026 01:56:45 +0000 [thread overview]
Message-ID: <20260512015646.3A36FC2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260511-ipq5210_wdt-v1-1-870c4b7f77b6@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string `qcom,apss-wdt-ipq5210` is not documented in the YAML device tree bindings.
--
commit b8d52e9b8c29f20f20c1b99e740ee76b20c2506c
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
arm64: dts: qcom: ipq5210: add watchdog node
This commit adds the watchdog device node for the IPQ5210 SoC to the device
tree.
> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> index 3761eb03ab246..2cdc10529c489 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
[ ... ]
> + watchdog@b017000 {
> + compatible = "qcom,apss-wdt-ipq5210", "qcom,kpss-wdt";
This isn't a bug, but is the "qcom,apss-wdt-ipq5210" compatible string
documented in the YAML bindings?
It doesn't appear to be added to the allowed enum list in
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml.
Would this omission result in a warning when running make dtbs_check?
> + reg = <0x0 0x0b017000 0x0 0x1000>;
> + interrupts = <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>;
> + clocks = <&sleep_clk>;
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-ipq5210_wdt-v1-1-870c4b7f77b6@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-05-12 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 10:56 [PATCH] arm64: dts: qcom: ipq5210: add watchdog node Kathiravan Thirumoorthy
2026-05-12 1:56 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512015646.3A36FC2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox