From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7483B2C11D6 for ; Tue, 12 May 2026 01:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778551114; cv=none; b=ig9y9oSwOqIsJSs4vmtLqz1Q+//Xgtfd0/6QH+daIn2unTC46mG1gbtA+Z9ehHqAWNHId/bjO+phfK2I/3yB1fb+/uZZFjjbFHz1Ei3DnJFwmm6jOnx6+pJG4JDi1XDoOBerc2WbJCnRv3apNx5wNgYgbmZE6IaKl+VcoqZrobQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778551114; c=relaxed/simple; bh=EFzY7OCt6QQM+kvuKl8Y9DqE3KwdZtxEdB9wlTOVvjs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=sbRxEcPbsX5pRYoi6vzCtcgwH2FlmWyErvqeYuUuUI2SLFtaF0hyS2WNSv3D07a1kh3162MedaMmxq2dprYYZA/mx/F8ImLJvn+syHuVcUq7CiyWTRf1NElvPPSLwIhXMgBMl/4mwlxxox7inUkl5mNtZQyCcfyP/op8kWGFeYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YIAj5lLf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YIAj5lLf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9463C2BCF7; Tue, 12 May 2026 01:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778551114; bh=EFzY7OCt6QQM+kvuKl8Y9DqE3KwdZtxEdB9wlTOVvjs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=YIAj5lLfTSYHcONU665ptILwczxXfeEn9dCwsUQpJwdicIS9bsB7+dB2pOuNliMdK gkMB0GzOk/K4CtHPJ1hzOpEe+RfTh+kaXtSpCZLs5Ly+2EAJAUVA/5bHkzfIkzYAsk UuEUwnX86XA2D32MScCCv1iMWJKhazV7ZrcmgH8MZ357eMg9GgQIlyFZcGtVdFXIcL Wv8r54tgJplCjakv2ad1bl15fXPSAWjE6eFGLzkemXrU5Q2MTD8qGAHKcqxIcx44hh yVE6+cuBXNRMMEiwma24CgCfx2X9oQX0QEqCiyk/55VemjwqP1nRd3KPGR7rN0pQY2 W2BWpji7M2TBQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v1 4/9 RESEND] ARM: tegra: grouper: Add support for front camera Reply-To: sashiko@lists.linux.dev To: "Svyatoslav Ryhel" Cc: devicetree@vger.kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org In-Reply-To: <20260511074859.24930-5-clamor95@gmail.com> References: <20260511074859.24930-5-clamor95@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 12 May 2026 01:58:33 +0000 Message-Id: <20260512015833.C9463C2BCF7@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Low] The 'orientation' property is not allowed by the 'aptina,mi1040' bi= nding schema. - [Low] Devicetree node name 'front-camera@48' does not follow generic nami= ng conventions. -- commit c5071430d670662429d8b5764f80cefdddb8903b Author: Svyatoslav Ryhel ARM: tegra: grouper: Add support for front camera This commit adds the front camera video path to the Tegra 30 Nexus 7 (grouper) device tree. It includes the necessary host1x, vi, and csi endpoints, a new camera node on the I2C bus, and updates the relevant power supply bindings. > diff --git a/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.= dtsi b/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi > index 15f53babdc217..892d718294dd1 100644 > --- a/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi > +++ b/arch/arm/boot/dts/nvidia/tegra30-asus-nexus7-grouper-common.dtsi [ ... ] > @@ -890,6 +978,36 @@ light-sensor@1c { > vdd-supply =3D <&vdd_3v3_sys>; > }; > =20 > + /* Aptina 1/6" HD SOC (MI1040) */ > + front-camera@48 { This isn't a bug, but does the node name front-camera@48 follow the Devicet= ree generic naming conventions? It might be better to use a generic name like camera@48 to avoid dtbs_check warnings. > + compatible =3D "aptina,mi1040"; > + reg =3D <0x48>; > + > + clocks =3D <&tegra_car TEGRA30_CLK_CSUS>; > + > + reset-gpios =3D <&gpio TEGRA_GPIO(O, 0) GPIO_ACTIVE_LOW>; > + > + vddio-supply =3D <&avdd_cam1>; > + vdd-supply =3D <&vddio_cam>; > + vaa-supply =3D <&avdd_cam1>; > + > + orientation =3D <0>; /* Front camera */ Is the orientation property supported by the aptina,mi1040 binding? The corresponding schema onnn,mt9m114.yaml sets additionalProperties: false at the root level and does not define the orientation property. It also does not reference the common video-interface-devices.yaml schema at the device node level. Could this inclusion cause a schema validation error during dtbs_check? > + > + assigned-clocks =3D <&tegra_car TEGRA30_CLK_VI_SENSOR>, > + <&tegra_car TEGRA30_CLK_CSUS>; [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260511074859.2493= 0-1-clamor95@gmail.com?part=3D4