Re: [PATCH v12 4/5] dt-bindings: mfd: Add binding for MediaTek MT6363 series SPMI PMIC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding provides interrupt controller capabilities but fails to list `interrupt-controller` and `#interrupt-cells` as required properties.
--

commit cec0b2a5ba52ef89e1723a3c01379c0aecebc8fa
Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

dt-bindings: mfd: Add binding for MediaTek MT6363 series SPMI PMIC

This commit adds a device tree binding for the MediaTek MT6363 and MT6373
multi-function PMICs connected over SPMI. These PMICs are found on board
designs using newer MediaTek SoCs.

> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml
> new file mode 100644
> index 0000000000000..ee90d16053e93
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml

[ ... ]

> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 3
> +
> +patternProperties:

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - '#address-cells'
> +  - '#size-cells'

Should interrupt-controller and #interrupt-cells be included in this
required list?

The binding provides interrupt controller capabilities but omits the
corresponding standard properties from the required block.

> +
> +additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511101355.122478-1-angelogioacchino.delregno@collabora.com?part=4