Re: [PATCH v2 2/6] riscv: dts: spacemit: k1-musepi-pro: add 24c04 eeprom

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mismatch between commit message specifying 24C04 EEPROM and the device tree implementation specifying 24C02.
--

commit 8474b79f5a61bfe2629e2e2bdbab9bc9128b8502
Author: Andre Heider <a.heider@gmail.com>

riscv: dts: spacemit: k1-musepi-pro: add 24c04 eeprom

This commit enables i2c2 and adds a connected EEPROM containing an ONIE
TLV table.

> diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> index 88c35ad1ef2ae..79415d760f162 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
[ ... ]
> @@ -92,6 +93,38 @@ &pdma {
>  	status = "okay";
>  };
>  
> +&i2c2 {
> +	pinctrl-0 = <&i2c2_0_cfg>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +
> +	eeprom@50 {
> +		compatible = "atmel,24c02";
> +		reg = <0x50>;
> +		vcc-supply = <&buck3_1v8>; /* EEPROM_VCC1V8 */
> +		pagesize = <8>;
> +		read-only;
> +		size = <256>;

The commit message states "add 24c04 eeprom", but the device tree uses the
atmel,24c02 compatible string, a page size of 8, and a total size of 256
bytes.

Since a 24c04 EEPROM is typically 512 bytes with a 16-byte page size, is
this hardware actually a 24c02, or does the device tree node need to be
updated to fully describe a 24c04?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511111116.1109643-1-a.heider@gmail.com?part=2