Re: [PATCH v2 2/3] arm64: dts: qcom: sm8550: add labels for thermal zones

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit claims to add labels for the cpu thermal zones but misses almost all of them.
--

commit c8dbf175273a7084796c662b38cf2e0899deb30a
Author: Alexandre Hamamdjian <azkali.limited@gmail.com>

arm64: dts: qcom: sm8550: add labels for thermal zones

This commit adds labels for the cpuss, cpu, and gpuss thermal zones so
board files can extend them with trip points and cooling maps.

> Add labels for the cpuss, cpu and gpuss thermal zones so board files
> can extend them with trip points and cooling maps through the &label
> override syntax, instead of redeclaring the zones by path.

Did this inadvertently skip most of the cpu thermal zones? 

The commit message mentions adding labels for the cpu thermal zones, but it
appears only cpu7-top-thermal is updated in the diff. The other CPU zones,
such as cpu0-thermal, cpu1-thermal, cpu2-thermal, cpu3-top-thermal,
cpu3-bottom-thermal, and so on, do not seem to receive labels here.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 912525e9bca6f..a9c678fc9cb2e 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi

[ ... ]

> @@ -6028,7 +6028,7 @@ cpu6_bottom_crit: cpu-critical {
>  			};
>  		};
>  
> -		cpu7-top-thermal {
> +		cpu7_top_thermal: cpu7-top-thermal {
>  			thermal-sensors = <&tsens0 13>;
>  
>  			trips {

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-pocketds-v2-0-299dd4247f2f@gmail.com?part=2