Re: [PATCH v10 1/6] dt-bindings: iio: adc: add AD4691 family

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The AD4691 binding introduces GPIO provider capabilities (`gpio-controller`, `#gpio-cells`) but fails to list them as required properties and omits them from the examples.
--

commit 3d6e918750431cd1fe37b615bc0436f12070ffa3
Author: Radu Sabau <radu.sabau@analog.com>

dt-bindings: iio: adc: add AD4691 family

This commit adds Device Tree bindings for the Analog Devices AD4691 family
of multichannel SAR ADCs. It describes the hardware connections, including
power domains, PWM, reset GPIO, and interrupt configurations.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml
> new file mode 100644
> index 0000000000000..af28a0c1cfa9e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - avdd-supply
> +  - vio-supply

Should gpio-controller and #gpio-cells be added to this required list?

The binding introduces GPIO provider capabilities, but these properties
are not marked as required. Subsystem guidelines indicate that when
hardware acts as a provider, the corresponding standard properties must
be included in the required list to ensure complete device tree nodes.

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    /* AD4692 in CNV Burst Mode with SPI offload */
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "adi,ad4692";
> +            reg = <0>;
> +            spi-cpol;
> +            spi-cpha;
> +            spi-max-frequency = <40000000>;
> +
> +            avdd-supply = <&avdd_supply>;
> +            ldo-in-supply = <&avdd_supply>;
> +            vio-supply = <&vio_supply>;
> +            ref-supply = <&ref_5v>;
> +
> +            reset-gpios = <&gpio0 15 GPIO_ACTIVE_LOW>;
> +
> +            pwms = <&pwm_gen 0 0>;
> +
> +            #trigger-source-cells = <1>;

Are the gpio-controller and #gpio-cells properties missing from this example?

The subsystem guidelines state that the examples section must include all
required properties to pass dt_binding_check.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-ad4692-multichannel-sar-adc-driver-v10-0-e1fbb1744e38@analog.com?part=1