From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 771A631B823; Tue, 12 May 2026 05:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778563259; cv=none; b=UXPJRAvwyT+nR2ohfzqY2srhdhYRIqXzE7fahlywSh40Tn7HRuwBah3uf3HPprcro1WYcvs83h5DIdnUoPk+n1hqp+cbA02I35pMxEs6Qtab6OEfAo4y/ksizGYrCVkGmpuv3b+OMfnvDT/mi8U+qtidStYOSnCMQl61jAC+0Dc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778563259; c=relaxed/simple; bh=DKykONumnN8vEAkNqUHocQNuYxuy08HseTU9qi3MfU4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YscpjAivI+UXfbRJqMDmCkNtyz5x0A8XZO4zpsqXeF4fkXsJn+s7SPKdVVYhwKriuwZMtN5OLbzLAok0AHVmd6oXdVEN6LlLyViAHti3/BDwGktTA1Ejod2U8fV7+xifxHLbfOZ4ZYngOmNRLmcgOc+1NgaKcnF2seGfEYJs0t8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ISF34sO4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ISF34sO4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85B96C2BCB8; Tue, 12 May 2026 05:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778563258; bh=DKykONumnN8vEAkNqUHocQNuYxuy08HseTU9qi3MfU4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ISF34sO4Kyt0LWF1g1Qy9SHd4SwpidsMOSdsluazACG6ullhYMhA/Hn3ZaPf0lCFu 6nz3rADFvJKXfBlqps+EAlz9Fi1MVJi/aKXXgbk9JTP9UPU5yRrdChrqFr4FmvdHJ0 h8+OmyE4aetyGCxlNmxVloa4LT15I9rxldJlqaTzk00OCC3fIeMgtz13wybdftlIHz T8B0QHJ/KytY5+t4sLH7UZzbytHf3iYXreOhjGgAoIwStGVM3VxvnrkKPzZ0J/6HaQ yorofaw4HfFiFhaUACELeqRqyZUUSIjV8yNlGfyANcZupMzvo3fSPEuAQfvdjLW8Td vTF78sUdtaYsA== Date: Tue, 12 May 2026 05:20:56 +0000 From: Yixun Lan To: Iker Pedrosa Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Ulf Hansson , Troy Mitchell , Michael Opdenacker , Javier Martinez Canillas , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Trevor Gamblin Subject: Re: [PATCH v9 8/8] riscv: dts: spacemit: k1-musepi-pro: add SD card support with UHS modes Message-ID: <20260512052056-GKD3624147@kernel.org> References: <20260511-orangepi-sd-card-uhs-v9-0-ae48c0b2b2cf@gmail.com> <20260511-orangepi-sd-card-uhs-v9-8-ae48c0b2b2cf@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260511-orangepi-sd-card-uhs-v9-8-ae48c0b2b2cf@gmail.com> Hi Iker, Trevor, On 10:54 Mon 11 May , Iker Pedrosa wrote: > From: Trevor Gamblin > > Update the Muse Pi Pro devicetree with SD card support to match what > was done for the OrangePi RV2 in [1]. More precisely: > > - Enable sdhci0 controller with 4-bit bus width > - Configure card detect GPIO with inversion > - Connect vmmc-supply to buck4 for 3.3V card power > - Connect vqmmc-supply to aldo1 for 1.8V/3.3V I/O switching > - Add dual pinctrl states for voltage-dependent pin configuration > - Support UHS-I SDR25, SDR50, and SDR104 modes > > [1] https://lore.kernel.org/linux-riscv/20260316-orangepi-sd-card-uhs-v3-0-aefd3b7832df@gmail.com/T/# > > Signed-off-by: Trevor Gamblin > Signed-off-by: Iker Pedrosa > --- > arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts | 66 ++++++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > index 29e333b670cf..774a4640f065 100644 > --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > @@ -18,6 +18,24 @@ aliases { > ethernet0 = ð0; > serial0 = &uart0; > }; Add one blank line here, but see comment below.. > + reg_dc_in: dc-in-5v { > + compatible = "regulator-fixed"; > + regulator-name = "dc_in_5v"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; reg_dc_in is not used, drop it, for the reason, see recent discussion of this thread here[1][2], especially refer to Krzysztof's original comment https://lore.kernel.org/all/6530526f-59ca-4753-a068-46c62a1a1fed@kernel.org/ [1] https://lore.kernel.org/all/20260511065338-GKA3624147@kernel.org/ [2] > + > + reg_vcc_4v: vcc-4v { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_4v"; > + regulator-min-microvolt = <4000000>; > + regulator-max-microvolt = <4000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > > chosen { > stdout-path = "serial0"; > @@ -77,3 +95,51 @@ &uart0 { > pinctrl-names = "default"; > status = "okay"; > }; > + > +&i2c8 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c8_cfg>; > + status = "okay"; > + > + pmic@41 { > + compatible = "spacemit,p1"; > + reg = <0x41>; > + interrupts = <64>; .. > + vin-supply = <®_vcc_4v>; This should be adjusted, please check schematics as I haven't done it myself, for reason behind please refer to this patch (which was merged in v7.1) http://lore.kernel.org/r/20260206-spacemit-p1-v4-1-8f695d93811e@riscstar.com > + > + regulators { > + buck4: buck4 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <3300000>; > + regulator-ramp-delay = <5000>; > + regulator-always-on; > + }; > + > + aldo1: aldo1 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <3400000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + }; > +}; > + > +&sdhci0 { > + pinctrl-names = "default", "uhs"; > + pinctrl-0 = <&mmc1_cfg>; > + pinctrl-1 = <&mmc1_uhs_cfg>; > + bus-width = <4>; > + cd-gpios = <&gpio K1_GPIO(80) GPIO_ACTIVE_HIGH>; > + cd-inverted; > + no-mmc; > + no-sdio; > + disable-wp; > + cap-sd-highspeed; > + vmmc-supply = <&buck4>; > + vqmmc-supply = <&aldo1>; > + sd-uhs-sdr25; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > + status = "okay"; > +}; > > -- > 2.54.0 > -- Yixun Lan (dlan)