From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3F19360ED3; Tue, 12 May 2026 11:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778586277; cv=none; b=ba8IAZispuD3/3t/BsHtDyfGfXCa0nZJLc1ETsnwAEeSoqBVItf+ZV3SDlsqxHLPo10txYXVW8YyKM1bY7yHWHg3TloCw77Wa7SOEkxjeFoDen7OXKYv8SoDlVHjBEGniYo77yUTYGxvVIoBDSCSRpsnH6tYUO6+iMzHPvRYaMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778586277; c=relaxed/simple; bh=jJ9Y3G6YF8uK918acH5+bW7b74nfHZoPK01spE4GgWs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sNHpnDvZcWqDDTLT6UPxvXayf/ivMuGAbGtS6guPglcHZkJ9ca9JpGBp/vnzshvy5AzKIFBoIsC/gQYntsSgyu9cFUmf74nQaBFyoD3DidpVmMA9dwjORG5TsQNOUEJEszhaXbXLr/MLl7eyl5CksqgEP5XSOPY/n3eMeZHsxzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N0kGPMUg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N0kGPMUg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04DFDC2BCB0; Tue, 12 May 2026 11:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778586277; bh=jJ9Y3G6YF8uK918acH5+bW7b74nfHZoPK01spE4GgWs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N0kGPMUgQx6aegtAMTz00t7GSD8CaGdz/CHReN52DEJB4JlzI7zEsHqi0S0qXWjHH rMJpj1bZ6adAn7QsDevyLm5jFvwvs0c/ib0lZ/PQ3RD1tbDLQ537dD4Y82NvyWMcOJ zRloE2hHHvlak1cR5JfixyowSjNKK+j87CD3470jJsvZxdgtzPVJWTBfps5wK4YlgF +yp8YgtQJHuMFTE3Fk33mQLVaDAxioOC/eoEsmdB2/JL/yl46abFAb7YiVMFOybgRy 1EXsTtGaUHsM+ZQ3qb/FClXEVVHZTxi9rD93qXibql4fH4OfuOg9QWa5QeKC/vnexE Kg0+kKP5MjoFg== Date: Tue, 12 May 2026 11:44:34 +0000 From: Yixun Lan To: Andre Heider Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] riscv: dts: spacemit: k1-musepi-pro: enable QSPI and add SPI NOR Message-ID: <20260512114434-GKI3624147@kernel.org> References: <20260511111116.1109643-1-a.heider@gmail.com> <20260511111116.1109643-4-a.heider@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260511111116.1109643-4-a.heider@gmail.com> Hi Andre, On 13:11 Mon 11 May , Andre Heider wrote: > Add the QSPI controller node and describe the attached SPI NOR flash > (Winbond W25Q64FWSSAQ). > > Add a corresponding vendor flash partition layout. > > Signed-off-by: Andre Heider > --- > .../riscv/boot/dts/spacemit/k1-musepi-pro.dts | 43 ++++++++++++++++++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > index 79415d760f162..7ebace0e46edb 100644 > --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > @@ -166,7 +166,7 @@ buck3_1v8: buck3 { > regulator-always-on; > }; > > - buck4 { > + buck4_3v3: buck4 { I'd prefer you make it right once in the first patch [1/6] which introduced this regulator.. please fix all similar issues in this series.. > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <3300000>; > regulator-ramp-delay = <5000>; > @@ -249,6 +249,47 @@ dldo7 { > }; > }; > > +&qspi { > + pinctrl-names = "default"; > + pinctrl-0 = <&qspi_cfg>; > + status = "okay"; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <26500000>; > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + vcc-supply = <&buck4_3v3>; /* QSPI_VCC1833 */ > + m25p,fast-read; > + > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + bootinfo@0 { > + reg = <0x0 0x10000>; > + }; > + private@10000 { > + reg = <0x10000 0x10000>; > + }; > + fsbl@20000 { > + reg = <0x20000 0x40000>; > + }; > + env@60000 { > + reg = <0x60000 0x10000>; > + }; > + opensbi@70000 { > + reg = <0x70000 0x30000>; > + }; > + uboot@a00000 { > + reg = <0xa0000 0x760000>; > + }; > + }; > + }; > +}; > + > &uart0 { > pinctrl-0 = <&uart0_2_cfg>; > pinctrl-names = "default"; > -- > 2.53.0 > -- Yixun Lan (dlan)