Re: [PATCH v8 v8 04/11] dt-bindings: iio: adc: hx711: add HX710B support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The HX710B-specific `dvdd-supply` property is not disabled for the older HX711 variant.
--

commit a13e8e56d6e7d72323b9da2a052824f6a63351ad
Author: Piyush Patle <piyushpatle228@gmail.com>

dt-bindings: iio: adc: hx711: add HX710B support

Add the avia,hx710b compatible and document the HX710B-specific DVDD and
VREF supplies. Update constraints to forbid HX711-only properties on HX710B
nodes and require vref-supply for HX710B, along with a new example.

> diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> index 9134bbe413796..b2b5c7bdf05e6 100644
> --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
[ ... ]
> @@ -53,6 +69,21 @@ properties:
>      maximum: 2500000
>      default: 400000
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: avia,hx710b
> +    then:
> +      properties:
> +        vsup-supply: false
> +        rate-gpios: false
> +      required:
> +        - vref-supply
> +    else:
> +      properties:
> +        vref-supply: false

The commit message introduces both DVDD and VREF as HX710B-specific
supplies. While vref-supply is properly forbidden in this else branch
for the older HX711 variant, dvdd-supply is omitted.

Should dvdd-supply: false also be included here to prevent incorrect
device tree configurations for HX711 from silently passing schema validation?

> +
>  required:
>    - compatible
>    - sck-gpios

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511174342.123820-1-piyushpatle228@gmail.com?part=4