Re: [PATCH net-next 2/3] dt-bindings: dpll: add SiTime SiT9531x clock generator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The schema omits the standard DPLL schema reference and uses `additionalProperties: false`, preventing the documentation of hardware wiring.
- [Low] The device node name in the examples violates the standard DPLL schema naming conventions.
--

commit 88ed321f90ac52e086a07eae925ac22020338107
Author: Ali Rouhi <rouhi.ali@gmail.com>

dt-bindings: dpll: add SiTime SiT9531x clock generator

This commit adds device tree binding documentation for the SiTime SiT95316
and SiT95317 DPLL clock generators.

> diff --git a/Documentation/devicetree/bindings/dpll/sitime,sit9531x.yaml b/Documentation/devicetree/bindings/dpll/sitime,sit9531x.yaml
> new file mode 100644
> index 0000000000000..0b05f0de65b9d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dpll/sitime,sit9531x.yaml

[ ... ]

> required:
>   - compatible
>   - reg
> 
> additionalProperties: false

The commit message notes the device tree describes the hardware wiring
for the inputs and outputs, and the driver parses standard DPLL properties
such as dpll-types, input-pins, and output-pins.

Should this schema include a reference to /schemas/dpll/dpll-device.yaml#
and use unevaluatedProperties: false instead? Without this, schema
validation will reject boards that configure the required DPLL wiring.

> 
> examples:
>   - |
>     i2c {
>         #address-cells = <1>;
>         #size-cells = <0>;
> 
>         clock-generator@68 {

This isn't a bug, but the node name clock-generator@68 does not follow
the standard DPLL naming convention. 

The core DPLL schema enforces the pattern ^dpll(@.*)?$. Could the node
names in these examples be updated to match the standard dpll pattern?

>             compatible = "sitime,sit95317";
>             reg = <0x68>;
>         };

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511211453.20671-1-arouhi@sitime.com?part=2