Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: Add Murata D1U74T PSU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The 'MURATA D1U74T PSU DRIVER' MAINTAINERS entry breaks alphabetical sorting.
- [Low] The devicetree example uses a non-standard node name 'psu@58'.
--

commit ff01149325e7be87488c4a95814dc42ab054bb39
Author: Abdurrahman Hussain <abdurrahman@nexthop.ai>

dt-bindings: hwmon: pmbus: Add Murata D1U74T PSU

This commit adds the devicetree binding documentation and MAINTAINERS entry
for the Murata D1U74T-W PMBus power supply unit.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/murata,d1u74t.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/murata,d1u74t.yaml
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/murata,d1u74t.yaml
[ ... ]
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        psu@58 {

Does this node name follow the standard devicetree specification? The
standard generic name for this class of device is typically "power-supply".
Should this be updated to "power-supply@58" rather than "psu@58" to better
reflect the generic function of the device?

> diff --git a/MAINTAINERS b/MAINTAINERS
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6803,6 +6803,12 @@ S:	Maintained
>  F:	Documentation/hwmon/crps.rst
>  F:	drivers/hwmon/pmbus/crps.c
>  
> +MURATA D1U74T PSU DRIVER
> +M:	Abdurrahman Hussain <abdurrahman@nexthop.ai>
> +L:	linux-hwmon@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/hwmon/pmbus/murata,d1u74t.yaml
> +
>  CRYPTO API

This isn't a bug, but it appears this entry was inserted out of alphabetical
order. Since "MURATA D1U74T PSU DRIVER" is currently placed just before
"CRYPTO API", should it be relocated further down the file into its proper
alphabetical position in the "M" section?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-d1u74t-v1-0-623c2bc1532a@nexthop.ai?part=1