Re: [PATCH v2] dt-bindings: i2c: convert davinci i2c to dt-schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The dt-schema conversion drops the mandatory requirement for the `power-domains` property on Keystone 2 66AK2G SoCs.
- [Medium] Typo in the maintainer's email address in the YAML schema.
--

commit 15717022cbf5ba5c5c00abf42db38f66896bb215
Author: Chaitanya Sabnis <chaitanya.msabnis@gmail.com>
Subject: dt-bindings: i2c: convert davinci i2c to dt-schema

This commit converts the Texas Instruments DaVinci and Keystone I2C controller
bindings from legacy text format to YAML. It makes the interrupts property
required and defines the ti,has-pfunc and power-domains properties.

Closes: https://lore.kernel.org/oe-kbuild-all/202605120133.lQ1F3qlY-lkp@intel.com/

> diff --git a/Documentation/devicetree/bindings/i2c/i2c-davinci.txt b/Documentation/devicetree/bindings/i2c/i2c-davinci.txt
> deleted file mode 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-davinci.txt
> +++ /dev/null

[ ... ]

> -SoC-specific Required Properties:
> -
> -The following are mandatory properties for Keystone 2 66AK2G SoCs only:
> -
> -- power-domains:	Should contain a phandle to a PM domain provider node

[ ... ]

> diff --git a/Documentation/devicetree/bindings/i2c/ti,davinci-i2c.yaml b/Documentation/devicetree/bindings/i2c/ti,davinci-i2c.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/ti,davinci-i2c.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/ti,davinci-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments DaVinci/Keystone I2C
> +
> +maintainers:
> +  - Chaitanya Sabnis <chaitanya.msabni@gmail.com>

This isn't a bug, but there's a typo in the email address. The address is
missing the trailing 's' compared to your author email.

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +
> +unevaluatedProperties: false

Does this conversion drop the mandatory requirement for the power-domains
property on Keystone 2 66AK2G SoCs?

The original text binding explicitly documented that power-domains is
mandatory for the ti,keystone-i2c compatible string. Should there be an allOf
conditional block added here to ensure incomplete device trees missing this
requirement do not silently pass schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512024851.4792-1-chaitanya.msabnis@gmail.com?part=1