Re: [PATCH v4 2/3] clk: eswin: Add eic7700 HSP clock driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The variable `val` is used uninitialized if `regmap_read()` fails in `hsp_clk_gate_is_enabled()`.
--

commit d3ad8b72eab107c1eceac1316c7d04ee9daab08d
Author: Xuyang Dong <dongxuyang@eswincomputing.com>

clk: eswin: Add eic7700 HSP clock driver

Add driver for the ESWIN EIC7700 high-speed peripherals system
clock controller and register an auxiliary device for system
reset controller which is named as "hsp-reset".

> diff --git a/drivers/clk/eswin/clk-eic7700-hsp.c b/drivers/clk/eswin/clk-eic7700-hsp.c
> new file mode 100644
> index 0000000000000..0d5bd5b705dc5
> --- /dev/null
> +++ b/drivers/clk/eswin/clk-eic7700-hsp.c

[ ... ]

> +static int hsp_clk_gate_is_enabled(struct clk_hw *hw)
> +{
> +	struct eic7700_hsp_clk_gate *gate = to_gate_clk(hw);
> +	unsigned int val;
> +
> +	regmap_read(gate->regmap, gate->reg, &val);

If regmap_read() fails and returns an error code, does it leave the val
variable uninitialized?

> +
> +	return !!(val & BIT(gate->bit_idx));

Could the clock framework evaluate this uninitialized stack memory as the
clock's state?

If a random garbage value is returned, could it lead to subsequent
synchronization or power-management issues, such as improperly disabling
an active clock?

> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512020432.671-1-dongxuyang@eswincomputing.com?part=2