From: sashiko-bot@kernel.org
To: "Chaitanya Sabnis" <chaitanya.msabnis@gmail.com>
Cc: krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: i2c: convert davinci i2c to dt-schema
Date: Wed, 13 May 2026 03:36:58 +0000 [thread overview]
Message-ID: <20260513033659.5EFAAC2BCC7@smtp.kernel.org> (raw)
In-Reply-To: <20260512030032.5006-1-chaitanya.msabnis@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `power-domains` property is no longer conditionally required for Keystone 2 SoCs, resulting in a schema validation regression.
--
commit 59b91f299ee992cf35096c3cc9cfd8f6ca312671
Author: Chaitanya Sabnis <chaitanya.msabnis@gmail.com>
dt-bindings: i2c: convert davinci i2c to dt-schema
This commit converts the Texas Instruments DaVinci and Keystone I2C
controller bindings from the legacy text format to modern dt-schema.
During the conversion, interrupts were made required and custom
properties were defined.
Closes: https://lore.kernel.org/oe-kbuild-all/202605120133.lQ1F3qlY-lkp@intel.com/
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-davinci.txt b/Documentation/devicetree/bindings/i2c/i2c-davinci.txt
> deleted file mode 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-davinci.txt
> +++ /dev/null
[ ... ]
> -SoC-specific Required Properties:
> -
> -The following are mandatory properties for Keystone 2 66AK2G SoCs only:
> -
> -- power-domains: Should contain a phandle to a PM domain provider node
> - and an args specifier containing the I2C device id
> - value. This property is as per the binding,
> - Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
[ ... ]
> diff --git a/Documentation/devicetree/bindings/i2c/ti,davinci-i2c.yaml b/Documentation/devicetree/bindings/i2c/ti,davinci-i2c.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/ti,davinci-i2c.yaml
[ ... ]
> +properties:
> + compatible:
> + enum:
> + - ti,davinci-i2c
> + - ti,keystone-i2c
[ ... ]
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
The legacy text binding explicitly stated that the power-domains property is
mandatory for Keystone 2 SoCs. Does the new YAML schema introduce a
validation regression by omitting this requirement?
Without an allOf conditional block enforcing power-domains when the
compatible string is ti,keystone-i2c, will incomplete device trees for
Keystone hardware silently pass validation?
Should an if-then block be added to explicitly require power-domains for the
ti,keystone-i2c compatible string?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260512030032.5006-1-chaitanya.msabnis@gmail.com?part=1
prev parent reply other threads:[~2026-05-13 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 3:00 [PATCH v3] dt-bindings: i2c: convert davinci i2c to dt-schema Chaitanya Sabnis
2026-05-12 10:06 ` Bartosz Golaszewski
2026-05-13 3:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513033659.5EFAAC2BCC7@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=chaitanya.msabnis@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox