Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kathiravan Thirumoorthy" <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add Qualcomm IPQ9650 GCC
Date: Wed, 13 May 2026 04:36:10 +0000	[thread overview]
Message-ID: <20260513043610.D11F6C2BCB7@smtp.kernel.org> (raw)
In-Reply-To: <20260512-ipq9650_boot_to_shell-v4-1-1e87c8326e59@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The binding description claims the module provides power domains, but the schema explicitly disables this capability.
--

commit 4db89a6dba2bb07dd7133c52ce96e3e38a472691
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

dt-bindings: clock: add Qualcomm IPQ9650 GCC

This commit adds the device tree binding for the Qualcomm IPQ9650 Global
Clock Controller. It includes the YAML schema and header files for the 
clocks and resets provided by the module.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9650-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9650-gcc.yaml
> new file mode 100644
> index 0000000000000..f33105217a062
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9650-gcc.yaml
[ ... ]
> +description: |
> +  Qualcomm global clock control module provides the clocks, resets and power
> +  domains on IPQ9650

This isn't a bug, but the description mentions that the module provides power
domains.

[ ... ]
> +  '#power-domain-cells': false

Does this controller actually provide power domains? The schema explicitly
disables them here, which suggests the mention of power domains in the
description might be a leftover from copying another binding.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-ipq9650_boot_to_shell-v4-0-1e87c8326e59@oss.qualcomm.com?part=1

  reply	other threads:[~2026-05-13  4:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  5:12 [PATCH v4 0/4] Add minimal boot support for Qualcomm IPQ9650 SoC Kathiravan Thirumoorthy
2026-05-12  5:12 ` [PATCH v4 1/4] dt-bindings: clock: add Qualcomm IPQ9650 GCC Kathiravan Thirumoorthy
2026-05-13  4:36   ` sashiko-bot [this message]
2026-05-12  5:12 ` [PATCH v4 2/4] clk: qcom: add Global Clock controller (GCC) driver for IPQ9650 SoC Kathiravan Thirumoorthy
2026-05-13  5:01   ` sashiko-bot
2026-05-12  5:12 ` [PATCH v4 3/4] dt-bindings: qcom: add IPQ9650 boards Kathiravan Thirumoorthy
2026-05-12  5:12 ` [PATCH v4 4/4] arm64: dts: qcom: add IPQ9650 SoC and rdp488 board support Kathiravan Thirumoorthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260513043610.D11F6C2BCB7@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox